Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-push.sh and dev-build-and-push.sh do not update kube-apiserver binary #5408

Closed
satnam6502 opened this issue Mar 12, 2015 · 7 comments · Fixed by #5415
Closed

kube-push.sh and dev-build-and-push.sh do not update kube-apiserver binary #5408

satnam6502 opened this issue Mar 12, 2015 · 7 comments · Fixed by #5415
Assignees
@zmerlynn
Labels
area/apiserver priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@satnam6502
Copy link
Contributor

I made several attempts to update the apiserver (i.e. kube-apiserver on the master) using kube-push.sh and dev-build-and-push.sh but they failed to update the binary. I noticed the same PID on the master for kube-apiserver and a long uptime. If I tore the cluster down and rebuilt it then I could see the change I made to the apiserver.
@satnam6502 satnam6502 added area/apiserver team/master priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 12, 2015
@satnam6502
Copy link
Contributor Author

@dchen1107 @davidopp @zmerlynn

@zmerlynn zmerlynn self-assigned this Mar 12, 2015
@zmerlynn
Copy link
Member

I'm actively working on it.

@dchen1107
Copy link
Member

I noticed exact the same issue today by update my kubelet binary.

@dchen1107 dchen1107 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 12, 2015
@zmerlynn
Copy link
Member

Push is broken, sorry. I thought I tested it, but the binaries aren't getting bonked appropriately.

@satnam6502 satnam6502 added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 12, 2015
@zmerlynn
Copy link
Member

kubelet binary push actually worked before? That path looked dubious at
best.
On Mar 12, 2015 3:56 PM, "Dawn Chen" notifications@github.com wrote:

I noticed exact the same issue today by update my kubelet binary.

—
Reply to this email directly or view it on GitHub
#5408 (comment)
.

zmerlynn added a commit to zmerlynn/kubernetes that referenced this issue Mar 12, 2015
@zmerlynn
Actually update binaries during kube-push
b02188b 
This was a dumb mistake during a re-factor of configure-vm. I tested
this early, re-factored the tail of this file, spot checked kube-push
and failed to test kube-push properly. My bad.

Fixes kubernetes#5361. Fixes kubernetes#5408.
@zmerlynn zmerlynn mentioned this issue Mar 12, 2015
Merged
@zmerlynn
Copy link
Member

I would appreciate external testing. I have done some sniff testing, but
push is a really broad use-case.

On Thu, Mar 12, 2015 at 4:51 PM, Satnam Singh notifications@github.com
wrote:

Closed #5408
#5408 via #5415
#5415.

—
Reply to this email directly or view it on GitHub
#5408 (comment)
.

@dchen1107 dchen1107 mentioned this issue Mar 13, 2015
Closed
@dchen1107
Copy link
Member

reopen this since the fix is reversed.

@dchen1107 dchen1107 reopened this Mar 13, 2015
akram pushed a commit to akram/kubernetes that referenced this issue Apr 7, 2015
@zmerlynn @akram
Actually update binaries during kube-push
48c5fde 
This was a dumb mistake during a re-factor of configure-vm. I tested
this early, re-factored the tail of this file, spot checked kube-push
and failed to test kube-push properly. My bad.

Fixes kubernetes#5361. Fixes kubernetes#5408.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmerlynn zmerlynn

Labels
area/apiserver priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Actually update binaries during kube-push zmerlynn/kubernetes
3 participants
@zmerlynn @satnam6502 @dchen1107