Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/proxy/proxier_test.go crash on OSX #5317

Closed
erictune opened this issue Mar 11, 2015 · 12 comments
Closed

pkg/proxy/proxier_test.go crash on OSX #5317

erictune opened this issue Mar 11, 2015 · 12 comments
Labels
area/test-infra kind/bug Categorizes issue or PR as related to a bug.

Comments

@erictune
Copy link
Member

pkg/proxy/proxier_test.go crashes on macos

ChooseHostInterface() returns an error and so NewProxier is nil, so stuff crashes.

@erictune
Copy link
Member Author

E0311 13:09:27.857647 90434 proxier.go:324] Failed to select a host interface: open /proc/net/route: no such file or directory

@erictune
Copy link
Member Author

There is no such thing as /proc on OSX.

I'd like it if unit tests worked on OSX.

@erictune
Copy link
Member Author

Ideally, unit tests would not interact with actual OS files like this. Maybe interface needs to be an arg to NewProxier.

@nikhiljindal nikhiljindal added area/test-infra kind/bug Categorizes issue or PR as related to a bug. labels Mar 12, 2015
@thockin
Copy link
Member

thockin commented Mar 12, 2015

@sub-mod tests should not be accessing /proc directly - must have missed that case. Can you take a look? I'm not immediately sure what the right fix is.

AFAIK there is no way tepo tell whether your code was built into a test or a real bin.

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

@erictune do you run kube on Mac ? or do you just build it and run it in Linux ?
@thockin the util_test is not accessing it.It is the proxier_test. Will change proxier_test.go

@erictune erictune changed the title pkg/proxy/proxier_test.go pkg/proxy/proxier_test.go crash on OSX Mar 12, 2015
@erictune
Copy link
Member Author

I run unit and integration tests directly on Mac.

@markturansky
Copy link
Contributor

@sub-mod I run kube and the unit tests on OS X, if I can be of help.

I've since updated from master and this is failing for me, too :)

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

@erictune @markturansky first of all apologies i didnot know about folks using mac.
I am just pushing my fix , pls wait. I ofcourse would need ur help

@markturansky
Copy link
Contributor

@sub-mod I will test it for you. Ping me here or on IRC.

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

@markturansky 5400 has my fix , can u kindly check

@sub-mod
Copy link
Contributor

sub-mod commented Mar 12, 2015

@erictune this is now fixed with #5400 . @markturansky kindly confirm here to close this thread.

@markturansky
Copy link
Contributor

This issue can be closed.

@thockin thockin closed this as completed Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-infra kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

5 participants