-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/proxy/proxier_test.go crash on OSX #5317
Comments
|
There is no such thing as /proc on OSX. I'd like it if unit tests worked on OSX. |
Ideally, unit tests would not interact with actual OS files like this. Maybe interface needs to be an arg to NewProxier. |
@sub-mod tests should not be accessing /proc directly - must have missed that case. Can you take a look? I'm not immediately sure what the right fix is. AFAIK there is no way tepo tell whether your code was built into a test or a real bin. |
I run unit and integration tests directly on Mac. |
@sub-mod I run kube and the unit tests on OS X, if I can be of help. I've since updated from master and this is failing for me, too :) |
@erictune @markturansky first of all apologies i didnot know about folks using mac. |
@sub-mod I will test it for you. Ping me here or on IRC. |
@markturansky 5400 has my fix , can u kindly check |
@erictune this is now fixed with #5400 . @markturansky kindly confirm here to close this thread. |
This issue can be closed. |
pkg/proxy/proxier_test.go crashes on macos
ChooseHostInterface() returns an error and so NewProxier is nil, so stuff crashes.
The text was updated successfully, but these errors were encountered: