@smarterclayton Could you please explain the cause of the failure in more detail? Do we not normalize the timezone in the representation used in the API?

When we serialize to JSON we are using a value that has a timezone embedded in it (time.Time). As a result the representation changed. We should normalize it as well during serialization, but in general creationTimestamp should not prevent an update since it can safely be ignored.

I think we should allow creationTimestamp to be empty and also convert time to UTC() before marshaling.

More specifically:

We'd also want to change:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/util/time.go#L92
to

    return json.Marshal(t.UTC().Format(time.RFC3339))

and
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/util/time.go#L81
to

    t.Time = pt.UTC()

Makes sense to me - clients should always control their timezone and with distributed masters you might see different values.

----- Original Message -----

I think we should allow creationTimestamp to be empty and also convert time
to UTC() before marshaling.

---

Reply to this email directly or view it on GitHub:
#5183 (comment)

I'll own the follow up on this.

----- Original Message -----

More specifically:

We'd also want to change:
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/util/time.go#L92
to

  return json.Marshal(t.UTC().Format(time.RFC3339))

and
https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/util/time.go#L81
to

  t.Time = pt.UTC()

---

Reply to this email directly or view it on GitHub:
#5183 (comment)

+1 for UTC serialization

Opened #5416 to marshal to utc when serializing

On Mar 10, 2015, at 6:08 AM, Jordan Liggitt notifications@github.com wrote:

+1 for UTC serialization

—
Reply to this email directly or view it on GitHub.