Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenAPI v3 #51163

Closed
mbohlool opened this issue Aug 23, 2017 · 8 comments
Closed

Support OpenAPI v3 #51163

mbohlool opened this issue Aug 23, 2017 · 8 comments
Labels
area/swagger kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@mbohlool
Copy link
Contributor

Now that OpenAPI released version 3.0 we should support it. We should keep the support for v2 until we have full tooling support for v3.

OpenAPI v3 Specification

Differences between v2 and v3

@mbohlool mbohlool added kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 23, 2017
@mbohlool mbohlool self-assigned this Aug 23, 2017
@munnerz
Copy link
Member

munnerz commented Oct 27, 2017

Now that #47263 has merged, it'd be great to be able to auto-generate schemas for our custom resource types.

@mbohlool have you had a chance to look at this yet? I'd be happy to take a look, although I'm not too sure where to start.

/cc @nikhita @sttts

@sttts
Copy link
Contributor

sttts commented Oct 27, 2017

@munnerz a good start is @mbohlool's PR from 1.8 adding OpenAPI aggregation in kube-apiserver: #50864. Probably apiextensions-apiserver "just" has to serve an OpenAPI spec built from the registered CRDs.

@mbohlool
Copy link
Contributor Author

@munnerz @sttts correct. Just serving an OpenAPI spec at /swagger.json should solve this. Your spec would have a constant part that is defining CRUD operations on CRD and then plugin the model there. I may not get to this in 1.9 so your help is appreciated here.

@mbohlool
Copy link
Contributor Author

Also I think this is the wrong issue to discuss CRD's OpenAPI support. For now we are supporting CRDs with OpenAPI v2. The spec generation in apiextensions-apiserver should somehow downgrade the model from v3 to v2. We need a new issue for this.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 29, 2018
@nikhita
Copy link
Member

nikhita commented Jan 29, 2018

/remove-lifecycle stale
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 29, 2018
@mbohlool mbohlool removed their assignment Apr 15, 2019
@roycaihw
Copy link
Member

roycaihw commented Dec 2, 2019

v3 spec requirement: #79472
v3 support KEP: kubernetes/enhancements#1263

/close

@k8s-ci-robot
Copy link
Contributor

@roycaihw: Closing this issue.

In response to this:

v3 spec requirement: #79472
v3 support KEP: kubernetes/enhancements#1263

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/swagger kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

7 participants