Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache mounts on the host #49793

Open
msau42 opened this issue Jul 28, 2017 · 7 comments
Open

Cache mounts on the host #49793

msau42 opened this issue Jul 28, 2017 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@msau42
Copy link
Member

msau42 commented Jul 28, 2017

Is this a BUG REPORT or FEATURE REQUEST?:
/kind feature
/sig storage

What happened:
In #48402 a new mount check was added to handle the case of bind mounts on directories (and not actual mount points). The new check has to iterate through all the mounts on the system, which could be time-consuming if there are many mounts. It may be worth looking into caching the mounts to optimize this check.
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jul 28, 2017
@msau42 msau42 mentioned this issue Aug 14, 2017
Merged
@msau42
Copy link
Member Author

msau42 commented Sep 23, 2017

cc @kubernetes/sig-storage-feature-requests

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2018
@msau42
Copy link
Member Author

msau42 commented Jan 8, 2018

/lifecycle frozen
/remove-lifecycle stale

More areas of the code are using the fully iterative mount check, so this will become more important as we start to scale the number of mounts allowed on a single system.

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 8, 2018
@cofyc
Copy link
Member

cofyc commented Mar 27, 2018

hi, @msau42 I'm going to work on this.

@cofyc cofyc mentioned this issue Mar 27, 2018
Closed
@msau42
Copy link
Member Author

msau42 commented Mar 27, 2018

/assign @cofyc

@k8s-ci-robot
Copy link
Contributor

@msau42: GitHub didn't allow me to assign the following users: cofyc.

Note that only kubernetes members and repo collaborators can be assigned.

In response to this:

/assign @cofyc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@krmayankk
Copy link

@msau42 @cofyc in my thinking , its premature to do caching until we have some numbers to say its hurting. What is the number of mount points typically beyond which this starts hurting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement mountpoints cache mechanism cofyc/kubernetes
5 participants
@cofyc @krmayankk @k8s-ci-robot @msau42 @fejta-bot