Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet should report last terminated container status #4919

Closed
dchen1107 opened this issue Feb 28, 2015 · 5 comments · Fixed by #6652
Closed

Kubelet should report last terminated container status #4919

dchen1107 opened this issue Feb 28, 2015 · 5 comments · Fixed by #6652
Assignees
@dchen1107
Labels
area/introspection priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone
v1.0

Comments

@dchen1107
Copy link
Member

Currently kubelet reports current status only. If pod's restart policy is not never, the last terminated container status will be override by the latest status, and lost. We should report last terminated container status.

I am going to update our v1beta3 api first, but will hold the implementation until we have #4561
@dchen1107 dchen1107 added priority/backlog Higher priority than priority/awaiting-more-evidence. area/introspection sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 28, 2015
@dchen1107 dchen1107 added this to the v1.0 milestone Feb 28, 2015
@dchen1107 dchen1107 self-assigned this Feb 28, 2015
@wojtek-t
Copy link
Member

@dchen1107 did you have a chance to start working on it?
IIUC, to support this we need to change the api (pkg/api/v1beta3/types.go), which IIUC from what @bgrant0607 wrote in some other thread should be done this week. I'm happy to help with it if you want me to help.

@bgrant0607
Copy link
Member

@wojtek-t Only breaking changes have a deadline. Additive changes can be done at any time.

@dchen1107
Copy link
Member Author

I am working on this. PR should be ready today or tomorrow.

@dchen1107
Copy link
Member Author

Also agree with @bgrant0607 This is not part of API breakage.

@dchen1107 dchen1107 mentioned this issue Mar 23, 2015
Merged
@wojtek-t
Copy link
Member

Thanks for answers & clarifications @bgrant0607 and @dchen1107

@dchen1107 dchen1107 mentioned this issue Mar 26, 2015
Closed
@dchen1107 dchen1107 mentioned this issue Apr 9, 2015
Merged
@therc therc mentioned this issue Apr 6, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchen1107 dchen1107

Labels
area/introspection priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Populate last terminated container information dchen1107/kubernetes-1
3 participants
@bgrant0607 @dchen1107 @wojtek-t