Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRI: missing seccomp profile in sandbox security context #49179

Closed
feiskyer opened this issue Jul 19, 2017 · 1 comment · Fixed by #49180
Closed

CRI: missing seccomp profile in sandbox security context #49179

feiskyer opened this issue Jul 19, 2017 · 1 comment · Fixed by #49180
Assignees
@feiskyer
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@feiskyer
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

When implementing the follow up of #46332 in #49178, I found that seccomp profile is missed in sandbox's security context. Without this, we couldn't honour "seccomp.security.alpha.kubernetes.io/pod" for sandbox.

/cc @yujuhong

/sig node
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Jul 19, 2017
@feiskyer
Copy link
Member Author

/assign

This was referenced Jul 19, 2017
Merged
Merged
k8s-github-robot pushed a commit that referenced this issue Jul 19, 2017
Merge pull request #49180 from feiskyer/seccomp
8a98983 
Automatic merge from submit-queue (batch tested with PRs 48981, 47316, 49180)

Add seccomp profile in sandbox security context

**What this PR does / why we need it**:

PR  #46332 adds seccomp profile to container security context, but not sandbox. This PR adds seccomp profile in sandbox security context. Without this, we couldn't honour "seccomp.security.alpha.kubernetes.io/pod" for sandbox.

**Which issue this PR fixes**

fixes #49179.

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```

/cc @yujuhong
k8s-github-robot pushed a commit that referenced this issue Aug 14, 2017
Merge pull request #49178 from feiskyer/seccomp-impl
b32639f 
Automatic merge from submit-queue

Support seccomp profile from container's security context

**What this PR does / why we need it**:

Support seccomp profile from container's security context, followup of #46332.

**Which issue this PR fixes** 

fixes #46332.

**Special notes for your reviewer**:

~~Depends on #49179. (already merged)~~

**Release note**:

```release-note
NONE
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feiskyer feiskyer

Labels
kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add seccomp profile in sandbox security context feiskyer/kubernetes
2 participants
@feiskyer @k8s-ci-robot