Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gating to API Compression handler #46963

Closed
ilackarms opened this issue Jun 5, 2017 · 2 comments · Fixed by #46966
Closed

Add gating to API Compression handler #46963

ilackarms opened this issue Jun 5, 2017 · 2 comments · Fixed by #46966
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@ilackarms
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature Request

PR #45666 adds gzip and flate compression to GET and LIST requests on API Objects. This issue is a feature request to add a feature gate to opt out of compression. (https://github.com/kubernetes/kubernetes/blob/master/pkg/features/kube_features.go#L117)
@k8s-github-robot
Copy link

@ilackarms There are no sig labels on this issue. Please add a sig label by:
(1) mentioning a sig: @kubernetes/sig-<team-name>-misc
(2) specifying the label manually: /sig <label>

Note: method (1) will trigger a notification to the team. You can find the team list here.

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 5, 2017
This was referenced Jun 5, 2017
Closed
Merged
Merged
@liggitt liggitt added this to the v1.7 milestone Jun 5, 2017
@liggitt liggitt added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 5, 2017
@lavalamp
Copy link
Member

Is this important for 1.7? Why? Is there an exception filed?

@lavalamp lavalamp removed this from the v1.7 milestone Jun 14, 2017
k8s-github-robot pushed a commit that referenced this issue Jun 23, 2017
Merge pull request #46966 from ilackarms/compression-gating
80af10c 
Automatic merge from submit-queue (batch tested with PRs 47883, 47179, 46966, 47982, 47945)

Add feature gating to REST Compression

**What this PR does / why we need it**: Adds feature gating to opt out of REST API compression

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #46963 

**Special notes for your reviewer**: This PR is a fix / addendum to #45666

**Release note**:

```release-note
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add feature gating to REST Compression ilackarms/kubernetes
4 participants
@lavalamp @liggitt @ilackarms @k8s-github-robot