Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hook initContainers into lifecycle #45931

Open
vromero opened this issue May 17, 2017 · 5 comments
Open

Hook initContainers into lifecycle #45931

vromero opened this issue May 17, 2017 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/apps Categorizes an issue or PR as relevant to SIG Apps.

Comments

@vromero
Copy link

vromero commented May 17, 2017

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST
Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.2", GitCommit:"477efc3cbe6a7effca06bd1452fa356e2201e1ee", GitTreeState:"clean", BuildDate:"2017-04-19T22:51:55Z", GoVersion:"go1.8.1", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"6", GitVersion:"v1.6.0", GitCommit:"fff5156092b56e6bd60fff75aad4dc9de6b6ef37", GitTreeState:"clean", BuildDate:"2017-05-09T23:22:45Z", GoVersion:"go1.7.3", Compiler:"gc", Platform:"linux/amd64"}

Environment:

  • Cloud provider or hardware configuration: minikube xhyve
  • OS (e.g. from /etc/os-release): macosx
  • Kernel (e.g. uname -a): Darwin ML-VSITZ-OSX-SF 16.4.0 Darwin Kernel Version 16.4.0: Thu Dec 22 22:53:21 PST 2016; root:xnu-3789.41.3~3/RELEASE_X86_64 x86_64
  • Install tools:
  • Others:

Feature:

initContainers feature works great for use cases when the initialization happens on the volumes. But oftentimes this initialization have to happen in the service itself, e.g: inject a datasource in grafana before grafana is considered ready: pre-ready.

initContainers feature doesn't seem o allow the container to be hooked to an specific moment of the lifecycle.

initContainers feature should allow the container to be hooked to an specific moment of the lifecycle.
@resouer
Copy link
Contributor

resouer commented May 19, 2017

There's already lifecycle hook, is not enough? https://kubernetes.io/docs/concepts/containers/container-lifecycle-hooks/

@grodrigues3 grodrigues3 added sig/apps Categorizes an issue or PR as relevant to SIG Apps. kind/feature Categorizes issue or PR as related to a new feature. labels May 19, 2017
@0xmichalis
Copy link
Contributor

initContainers feature works great for use cases when the initialization happens on the volumes. But oftentimes this initialization have to happen in the service itself, e.g: inject a datasource in grafana before grafana is considered ready: pre-ready.

@kubernetes/sig-apps-feature-requests another request that is satisfied by hooks (#14512) / auto-pausing (#11505).

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 23, 2018
@dvdgsng
Copy link

dvdgsng commented Jan 31, 2018 •
edited
Loading

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jan 31, 2018
@kow3ns kow3ns removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Mar 3, 2018
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
SIG Apps
Status: Needs Triage
Milestone
No milestone
Development

No branches or pull requests
8 participants
@vromero @resouer @0xmichalis @dvdgsng @grodrigues3 @kow3ns @k8s-ci-robot @fejta-bot