Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow compression of json response body using Accept-Encoding header #44164

Closed
ilackarms opened this issue Apr 6, 2017 · 4 comments
Closed

Allow compression of json response body using Accept-Encoding header #44164

ilackarms opened this issue Apr 6, 2017 · 4 comments
Labels
area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Milestone
v1.7

Comments

@ilackarms
Copy link
Contributor

ilackarms commented Apr 6, 2017 •
edited
Loading

Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see http://kubernetes.io/docs/troubleshooting/.):
No

What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.):
compression, gzip, response, json

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
Feature Request

JSON payload returned by Kubernetes can be very large on GET requests when there are a lot of managed resources in the cluster.

Currently it is not possible to specify that large response bodies should be compressed via request headers.

Specifying the Accept-Encoding header on a GET request should cause the k8s apiserver to respond with response Body compressed with the given encoding sceme (e..g gzip, bzip2, etc.)
@ilackarms ilackarms changed the title Allow compression of json response body using Content-Encoding header Allow compression of json response body using Accept-Encoding header Apr 17, 2017
@ilackarms ilackarms mentioned this issue May 11, 2017
Merged
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2017
@ilackarms
Copy link
Contributor Author

#45666 adds this feature

@0xmichalis
Copy link
Contributor

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 4, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 4, 2017
@deads2k
Copy link
Contributor

deads2k commented Jun 5, 2017

@ilackarms link your pull and tag me when have it open so we can be sure it makes 1.7

@ilackarms
Copy link
Contributor Author

gating issue #46963

@deads2k deads2k added this to the v1.7 milestone Jun 6, 2017
ilackarms added a commit to ilackarms/kubernetes that referenced this issue Jun 6, 2017
@ilackarms
add gzip compression to GET and LIST requests
fc650a5 
closes kubernetes#44164
k8s-github-robot pushed a commit that referenced this issue Jun 6, 2017
Merge pull request #45666 from ilackarms/compression
cc568f6 
Automatic merge from submit-queue

add gzip compression to GET and LIST requests

Fixes #44164



Enable compressed response bodies for non-watch GET and LIST requests on API Objects.

**What this PR does / why we need it**: Adds compression via Accept-Encoding header, returns Content-Encoding header on responses (only supports gzip at this time). Enabled solely for GET and LIST requests which can return very large response bodies. 

**Special notes for your reviewer**:

See #44164 for discussion.

**Release note**:

```release-note-
```
@cben cben mentioned this issue Dec 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
v1.7
Development

No branches or pull requests
6 participants
@liggitt @0xmichalis @ilackarms @deads2k @k8s-github-robot @k8s-ci-robot