Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube-down.sh fails on v0.9.0 #3741

Closed
vishh opened this issue Jan 22, 2015 · 7 comments
Closed

kube-down.sh fails on v0.9.0 #3741

vishh opened this issue Jan 22, 2015 · 7 comments
Assignees
@satnam6502
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@vishh
Copy link
Contributor

vishh commented Jan 22, 2015

The bug is in 'teardown-logging' function in cluster/gce/util.sh where the 'PROJECT' variable is undefined.
/tmp/0.9.0/kubernetes/cluster/../cluster/gce/util.sh: line 832: PROJECT: unbound variable

This bug has been fixed on HEAD by #3620.
@satnam6502
Copy link
Contributor

Do you mean teardown-logging-firewall ?
This has a detect-project call in it: so I am confused about why the project is not set?

@dchen1107
Copy link
Member

@brendandburns Should we patch 0.9 release with the fix for this issue too?

@dchen1107
Copy link
Member

Also shouldn't this failure detect by e2e test?

@zmerlynn
Copy link
Member

I actually requested a cherry pick of #3601 (for GKE), which would also fix this, yes?

@vishh
Copy link
Contributor Author

vishh commented Jan 22, 2015

@satnam6502: Look at the version of gce/util.sh released as part of v0.9.0.
@zmerlynn: Yup. #3601 should fix it.

@zmerlynn
Copy link
Member

@brendanburns: I know you're OOO, but okay to cherry-pick #3601 for 0.9.1?

@dchen1107: It should be caught by e2e. I'm not clear what's going on there, and was a little mystified as to why it was working when I changed it. (I assumed it was getting picked up by a sourced script from previously.)

@goltermann goltermann added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 28, 2015
@goltermann
Copy link
Contributor

Already in 0.9.1.

@swatisehgal swatisehgal mentioned this issue Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satnam6502 satnam6502

Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zmerlynn @satnam6502 @vishh @dchen1107 @goltermann