Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flocker volume driver should use StorageClass parameters to determine the Flocker Storage profile of dynamically provisioned volumes #34810

Closed
wallrj opened this issue Oct 14, 2016 · 4 comments
Closed

Flocker volume driver should use StorageClass parameters to determine the Flocker Storage profile of dynamically provisioned volumes #34810

wallrj opened this issue Oct 14, 2016 · 4 comments
Labels
area/kubectl lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@wallrj
Copy link
Contributor

wallrj commented Oct 14, 2016

Since #31005 the Flocker volume driver supports dynamic volume provisioning. It creates Flocker datasets with a size matching that of the PVC.
It currently ignores the StorageClass annotation of the PVC.
Instead it should use the parameters of the StorageClass to choose the Flocker dataset profile of the new Flocker dataset.

The profile is specified by including the keyword "clusterhq:flocker:profile"

among the metadata supplied to the Flocker create_dataset API.

Demonstrated here in the Flocker Docker plugin:

See #29006 for an example of how StorageClass parameters are used by the GCE PD volume driver to select either GCE SSD or spinning disks.
@msau42
Copy link
Member

msau42 commented May 22, 2017

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 22, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 24, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 24, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/kubectl lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@wallrj @k8s-github-robot @k8s-ci-robot @msau42 @fejta-bot