Skip to content

Expand test coverage for affinity #34253

Closed
@ConnorDoyle

Description

Quoting @davidopp from issue 22985 (comment):

I would do the topologKeys in the priority tests differently (to test something more realistic). The tests are correct, they just aren't the typical scenarios, like two nodes with the same zone and different hostname, plus one node in a different zone. (you wrote them before I clarified how topologyKey works). This wouldn't require major changes, mostly just changes to the node labels and topologyKey in the affinity requests. Also, I think it would be better if the priority tests all had more than two nodes, because when you only have two nodes, the only priority scores you can have are 0 and 10, so it's hard to know if the actual weights that were computed (before normalizing) were correct.

Metadata

Assignees

Labels

area/node-e2earea/testlifecycle/rottenDenotes an issue or PR that has aged beyond stale and will be auto-closed.sig/schedulingCategorizes an issue or PR as relevant to SIG Scheduling.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions