-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: document in release notes if in-place upgrade should work #33954
Comments
cc @ashw7n |
Related issue: #23104 |
(And I think the thing we should do here is set up a test job that does an in-place upgrade and fails if any pods restart.) |
Good idea, especially since 1.4 release, we start to break the bundle release (kubelet & docker) at the node. On the test side, once we automated upgrade test suite, we can add the test to check pods / container. |
Issues go stale after 30d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
In talking with a user, I've realized that we should say in release notes if it's safe to do an in-place kubelet upgrade, or if users should do a drain/upgrade/undrain cycle for each node. We should include a table, actually, in case users are trailing by more than one version.
(In the past we have change the hashing function that kubelet uses to name docker containers, causing all containers on a node to get restarted if you do an in-place upgrade.)
Filing this so we don't forget.
The text was updated successfully, but these errors were encountered: