Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubelet: document in release notes if in-place upgrade should work #33954

Closed
lavalamp opened this issue Oct 3, 2016 · 7 comments
Closed

kubelet: document in release notes if in-place upgrade should work #33954

lavalamp opened this issue Oct 3, 2016 · 7 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@lavalamp
Copy link
Member

lavalamp commented Oct 3, 2016

In talking with a user, I've realized that we should say in release notes if it's safe to do an in-place kubelet upgrade, or if users should do a drain/upgrade/undrain cycle for each node. We should include a table, actually, in case users are trailing by more than one version.

(In the past we have change the hashing function that kubelet uses to name docker containers, causing all containers on a node to get restarted if you do an in-place upgrade.)

Filing this so we don't forget.

@lavalamp lavalamp added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Oct 3, 2016
@uruddarraju
Copy link

cc @ashw7n

@uruddarraju
Copy link

Related issue: #23104

@lavalamp
Copy link
Member Author

lavalamp commented Oct 3, 2016

(And I think the thing we should do here is set up a test job that does an in-place upgrade and fails if any pods restart.)

@dchen1107
Copy link
Member

Good idea, especially since 1.4 release, we start to break the bundle release (kubelet & docker) at the node.

On the test side, once we automated upgrade test suite, we can add the test to check pods / container.

@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 17, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 17, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

5 participants