Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need "action required" notes in CHANGELOG.md #28405

Closed
erictune opened this issue Jul 2, 2016 · 4 comments
Closed

Need "action required" notes in CHANGELOG.md #28405

erictune opened this issue Jul 2, 2016 · 4 comments
Assignees
Labels
area/kubectl lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@erictune
Copy link
Member

erictune commented Jul 2, 2016

We need to fill in the "action required" section of our release notes (in kubernetes/CHANGELOG.md).

Rather than everyone sending a PR against CHANGELOG.md, and having lots of merge conflicts, let's take advantage of the automatic release note generation that @david-mcmahon has written (thanks! it is a big improvement over 1.2).

For that to work, I need is for everyone who wrote a PR that requires action from the user to make sure that PR has the release-note-action-required label is on their PR. It doesn't matter that it already merged. We will regenerate with the latest labels. I also need anyone who wrote a PR that has that label to make sure that it is really required, and remove it if it is not. If it is requred, please make sure it has a "release-note" block in the first comment of the PR which describes that the user needs to do. A good example of this is #28132

Most of the PRs with the release-note-action-required label do not have this.

Once that is done, we will regenerate the release notes (also need to fix kubernetes/release#26)

Specific PRs with this label which are in 1.3, at the time of writing:

@erictune erictune self-assigned this Jul 2, 2016
@erictune
Copy link
Member Author

erictune commented Jul 6, 2016

#25072 and #25006 will be documented via PR #28564

#28403 added a bunch of known issues.

Only #22897 and #26796 are unknown at this point.

@k8s-github-robot k8s-github-robot added area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Aug 3, 2016
@fejta-bot
Copy link

Issues go stale after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2017
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 15, 2018
@david-mcmahon
Copy link
Contributor

I would say this is now handled by the release note drafts that accompany our regular minor releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/kubectl lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Development

No branches or pull requests

5 participants