@guoshimin this is an alpha feature, and may has problem. More specifically, when we register node in kubelet, we always use Create, maybe we should use UpdateOrCreate here. @kubernetes/sig-node

This is a known issue and that's why the feature is still alpha. There is no concept of label ownership as of now since labels can be added to the node object from multiple sources.
We need to update kubelet to checkpoint the flags that it currently owns and use that knowledge while updating flags in the future.

A possible workaround meanwhile will be that of having kubelet delete existing flags and adding the new flags specified via --node-labels flags everytime it restarts.

Related #25811

@vishh do you know if there is an assignee for for 1.4. Our ops folks are not fond of having to manage node configs in maintain label sanity across restarts.

/cc @twiest @scollier

@timothysc No one is working on completing node labels AFAIK.

cc @dchen1107

I would do this if we decide to persist node labels at last.

switching this to 1.6 as it's too late for 1.5. ok? (please switch it right back if you disagree)

@dims I think we still don't make a final decision.

Ack @adohe please adjust milestone when appropriate

@adohe Can you please triage this issue by EOD Friday. Is this a 1.5 issue or can it be punted to 1.6? If it is a 1.5 issue is it a blocker for the release (meaning release must wait for this to be fixed), or a non-blocker?

I don't think this can be a release blocker since it's not a bug. This feature functions as documented. fixing this issue is an additional feature, not a bugfix.

This can't break customers since it's been as-is (and as-documented) for multiple releases now.

I see no reason this additional feature (which requires additional kubelet persistence and has zero work thusfar) should go in post-feature freeze and shouldn't be targeted at 1.6.

Happy to be corrected if I'm misunderstanding anything

excellent @euank punting it to 1.6 :)

Relies on #29459

@resouer What is the status of this for 1.6?

This is not targeted for 1.6 at all, and no assignee. We need to first finish #29459 for kubelet config in general, then come back with the node labels.

I've confirmed this has been fixed #46254