Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingress tests panic invoking framework.BeforeEach #27486

Closed
bprashanth opened this issue Jun 15, 2016 · 2 comments
Closed

Ingress tests panic invoking framework.BeforeEach #27486

bprashanth opened this issue Jun 15, 2016 · 2 comments
Assignees
@bprashanth
Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@bprashanth
Copy link
Contributor

Sometime yesterday the test started panicking because the framework is nil. No changes were made to the test, did we change framework setup?

This is the stack

10:04:22 
10:04:22   Test Panicked
10:04:22   runtime error: invalid memory address or nil pointer dereference
10:04:22   /usr/local/go/src/runtime/panic.go:443
10:04:22 
10:04:22   Full Stack Trace
10:04:22    /usr/local/go/src/runtime/panic.go:443 +0x4e9
10:04:22   k8s.io/kubernetes/test/e2e/framework.(*Framework).BeforeEach(0xc820134480)
10:04:22    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/framework/framework.go:142 +0xeb
10:04:22   k8s.io/kubernetes/test/e2e.glob.func38.1()
10:04:22    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/ingress.go:401 +0xe8
10:04:22   k8s.io/kubernetes/vendor/github.com/onsi/ginkgo/internal/leafnodes.(*runner).runSync(0xc82001b320, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
10:04:22    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/e2e.go:243 +0x3c5
10:04:22   k8s.io/kubernetes/test/e2e.TestE2E(0xc8200a6870)
10:04:22    /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/e2e_test.go:30 +0x21
10:04:22   testing.tRunner(0xc8200a6870, 0x3594880)
10:04:22    /usr/local/go/src/testing/testing.go:473 +0x98
10:04:22   created by testing.RunTests
10:04:22    /usr/local/go/src/testing/testing.go:582 +0x892
10:04:22
@bprashanth bprashanth added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/network Categorizes an issue or PR as relevant to SIG Network. team/cluster area/test-infra kind/flake Categorizes issue or PR as related to a flaky test. labels Jun 15, 2016
@bprashanth bprashanth self-assigned this Jun 15, 2016
@bprashanth bprashanth mentioned this issue Jun 15, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Jun 16, 2016
Merge pull request #27488 from bprashanth/ing_e2e_fix
cec153c 
Automatic merge from submit-queue

Call NewFramework constructor instead of hand creating framework.

#27486, probably because we defined a new clientConfigGetter for node e2es and this test was hand creating the framework.
@bprashanth
Copy link
Contributor Author

bprashanth commented Jun 16, 2016 •
edited
Loading

Aarg now it looks like we inverted the order of running framework.AfterEach and custom AfterEach, so I re-invoke framework.AfterEach in my AfterEach (we used to need this) and it crashes. I'm just going to usher #26821 in as it doesn't invoke framework.AfterEach.

For the record this will keep failing on 1.3 till the 26821 is cherrypicked, but the diff between 1.3 and HEAD is insignificant at this point (and remain insignificant till the cherrypick happens)

@bprashanth bprashanth mentioned this issue Jun 16, 2016
Merged
@bprashanth
Copy link
Contributor Author

Now gce-1.3 passes but http://kubekins.dls.corp.google.com/job/kubernetes-e2e-gke-ingress-release-1.3/ will fail because #27741 went in without #27814. They should pass when 27814 is cherrypicked to 1.3 (#27813 for context)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bprashanth bprashanth

Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fejta @bprashanth