Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set "burst" rate to zero for node evictions in NodeController #27413

Closed
davidopp opened this issue Jun 15, 2016 · 7 comments
Closed

Set "burst" rate to zero for node evictions in NodeController #27413

davidopp opened this issue Jun 15, 2016 · 7 comments
Assignees
@gmarek
Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v1.3

Comments

@davidopp
Copy link
Member

Is there any good reason to have a nonzero burst rate? Ten is way too high for small clusters, and the number seems to be chosen at random even for large clusters (it's not really the size of any typical failure domain). I think that for now we should set it to zero.

@gmarek Does this sound reasonable to you?
@davidopp davidopp added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. team/control-plane labels Jun 15, 2016
@davidopp davidopp added this to the v1.3 milestone Jun 15, 2016
@gmarek
Copy link
Contributor

gmarek commented Jun 15, 2016

I think that by 0 you mean 1. Goal of #20979 was to set it in some sane way. I'll send a simple PR changing it to 1.

@davidopp
Copy link
Member Author

Yeah sorry, I meant 1.

I'm not suggesting to do the full-blown "make rate proportional to cluster size" thing right now, just to change the burst.

@gmarek gmarek mentioned this issue Jun 15, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Jun 15, 2016
Merge pull request #27422 from gmarek/burst
e570329 
Automatic merge from submit-queue

Change default value of deleting-pods-burst to 1

Fix. #27413
@goltermann
Copy link
Contributor

#27422 got merged, can this be closed?

@davidopp
Copy link
Member Author

Yes, thanks for noticing.

@gmarek
Copy link
Contributor

gmarek commented Jun 16, 2016

@goltermann - do you know what description should a PR have to auto close the issue?

@davidopp
Copy link
Member Author

I think the problem is that you put a stray period after "Fix"

@davidopp
Copy link
Member Author

https://help.github.com/articles/closing-issues-via-commit-messages/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmarek gmarek

Labels
priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
3 participants
@gmarek @davidopp @goltermann