Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address outstanding DNS review comments in #26694 #26921

Closed
ghost opened this issue Jun 6, 2016 · 9 comments
Closed

Address outstanding DNS review comments in #26694 #26921

ghost opened this issue Jun 6, 2016 · 9 comments
Assignees
Labels
area/federation milestone/removed priority/backlog Higher priority than priority/awaiting-more-evidence. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster.

Comments

@ghost
Copy link

ghost commented Jun 6, 2016

See #26694 for details. Specifically:

  1. Don't call ensureDnsRecords() if the DNS provider has not been initialized.
  2. Don't discard errors returned by getClusterZoneNames()

cc: @mfanjie FYI

@ghost ghost added priority/backlog Higher priority than priority/awaiting-more-evidence. team/control-plane labels Jun 6, 2016
@ghost ghost self-assigned this Jun 6, 2016
@ghost ghost added this to the v1.4 milestone Aug 18, 2016
@goltermann
Copy link
Contributor

@quinton-hoole this is P2...time to punt to v1.5?

@ghost
Copy link
Author

ghost commented Sep 6, 2016

@golterman Yes, 1.5 is fine. I seem to have lost the authority to update the Milestone? Did you perhaps change permissions?

@goltermann goltermann modified the milestones: v1.5, v1.4 Sep 6, 2016
@goltermann
Copy link
Contributor

I moved it - no idea why you wouldn't have permission on the kubernetes repo.

@dims
Copy link
Member

dims commented Nov 15, 2016

ok to move this to 1.6? please holler if not appropriate

@dims dims modified the milestones: v1.6, v1.5 Nov 15, 2016
@ghost
Copy link
Author

ghost commented Nov 18, 2016

Reassigning to @nikhiljindal in case he wants to address this in future. @mfanjie would also be a suitable candidate.

@ghost ghost assigned nikhiljindal and unassigned ghost Nov 18, 2016
@ethernetdan
Copy link
Contributor

Moving to 1.7 as late to happen in 1.6. Feel free to switch back if this is incorrect.

@ethernetdan ethernetdan modified the milestones: v1.7, v1.6 Mar 13, 2017
@marun
Copy link
Contributor

marun commented Jun 12, 2017

Not a release blocker for 1.7.

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Removed

@nikhiljindal @quinton-hoole

Important:
This issue was missing labels required for the v1.8 milestone for more than 7 days:

kind: Must specify exactly one of [kind/bug, kind/cleanup, kind/feature].
priority: Must specify exactly one of [priority/critical-urgent, priority/important-longterm, priority/important-soon].

Removing it from the milestone.

Additional instructions available here The commands available for adding these labels are documented here

@csbell csbell added sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. and removed sig/federation labels Oct 10, 2017
@irfanurrehman
Copy link
Contributor

This issue was labelled only for sig/multicluster and is thus moved over to kubernetes-retired/federation#48.
If this does not seem to be right, please reopen this and notify us @kubernetes/sig-multicluster-misc.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/federation milestone/removed priority/backlog Higher priority than priority/awaiting-more-evidence. sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster.
Projects
None yet
Development

No branches or pull requests

10 participants