Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Route53 dnsprovider: address outstanding review comments #26668

Closed
ghost opened this issue Jun 1, 2016 · 1 comment
Closed

AWS Route53 dnsprovider: address outstanding review comments #26668

ghost opened this issue Jun 1, 2016 · 1 comment
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
next-candidate

Comments

@ghost
Copy link

ghost commented Jun 1, 2016

See outstanding review comments in #26049

Specifically:

  1. removing boolean's from dnsprovider interface,
  2. pointer receivers rather than value receivers.
  3. Handle result truncation

FYI @nikhiljindal
@ghost ghost added this to the v1.4 milestone Jun 1, 2016
@ghost ghost self-assigned this Jun 1, 2016
@ghost ghost added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 18, 2016
@ghost
Copy link
Author

ghost commented Aug 18, 2016

Most of this is done in a recent PR by @justinsb. We can to the rest post-v1.4. Kicking out of this milestone.

@ghost ghost modified the milestones: next-candidate, v1.4 Aug 18, 2016
@ghost ghost closed this as completed Nov 18, 2016
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
next-candidate
Development

No branches or pull requests
0 participants