Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach Detach Controller Data Structs should be keyed of opaque type #26250

Closed
saad-ali opened this issue May 25, 2016 · 1 comment
Closed

Attach Detach Controller Data Structs should be keyed of opaque type #26250

saad-ali opened this issue May 25, 2016 · 1 comment
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@saad-ali
Copy link
Member

Attach Detach Controller Data Structs ("actual state of world", "desired state of world", etc.) use strings as keys for pod/volume/node types. Instead they should use opaque types to get the benefits of type safety.
@saad-ali saad-ali added priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/storage Categorizes an issue or PR as relevant to SIG Storage. team/cluster labels May 25, 2016
@saad-ali saad-ali mentioned this issue May 25, 2016
Merged
@saad-ali
Copy link
Member Author

Closed with #26801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saad-ali