Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#19242 breaks compatibility of command line args on kube-controller-manager #26002

Closed
mikedanese opened this issue May 21, 2016 · 6 comments
Closed

#19242 breaks compatibility of command line args on kube-controller-manager #26002

mikedanese opened this issue May 21, 2016 · 6 comments
Assignees
@gmarek
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v1.3

Comments

@mikedanese
Copy link
Member

mikedanese commented May 21, 2016 •
edited
Loading

Not specifying --service-cluster-ip-range added in #19242 causes a panic in nodecontroller which causes controller-manager to crash loop.

This feels like a v1.3 blocker.

Ref #19242

@bgrant0607 @mhrgoog @mqliang @wojtek-t @gmarek @lavalamp @goltermann @davidopp
@mikedanese mikedanese added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. team/control-plane labels May 21, 2016
@mikedanese mikedanese added this to the v1.3 milestone May 21, 2016
@mikedanese
Copy link
Member Author 

 I0520 22:21:43.539213    2933 plugins.go:71] No cloud provider specified.
 I0520 22:21:43.539397    2933 nodecontroller.go:157] Sending events to apiserver.
 panic: runtime error: invalid memory address or nil pointer dereference [signal 0xb code=0x1 addr=0x0 pc=0x7f28ab]
 goroutine 1 [running]:
 panic(0x2303e40, 0xc82000e100)
         /usr/local/go/src/runtime/panic.go:481 +0x3e6

k8s.io/kubernetes/pkg/controller/node.(*NodeController).filterOutServiceRange(0xc820144000)
         /go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/pkg/controller/node/nodecontroller.go:342+0x2b
 k8s.io/kubernetes/pkg/controller/node.(*NodeController).Run(0xc820144000,0x2540be400)

@mqliang
Copy link
Contributor

mqliang commented May 21, 2016

Sorry, I am not familiar with the code under /cluster and /test.

@bgrant0607
Copy link
Member

@mqliang @gmarek @wojtek-t Component flags constitute an API, with similar compatibility rules. We can't add new required flags to binaries. That breaks all existing Kubernetes cluster deployment code.

@mikedanese
Copy link
Member Author

@mqliang no worries. We should have caught these errors in the PR builder. It's an item to increase coverage in pre-submit PR checks

@euank euank mentioned this issue May 21, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue May 21, 2016
Merge pull request #26006 from euank/service-cluster-ip-range
5c08302 
Automatic merge from submit-queue

cluster/gce/coreos: Set service-cluster-ip-range

Broken by #19242 

See also #26002 

This is necessary to kube-up for me, but depending on how #26002 plays out, this PR might not be necessary. Happy to close this or merge or whatever depending on what's best.

cc @yifan-gu @sjpotter @mikedanese
@zmerlynn
Copy link
Member

Sorry, I should have caught this in review, too. This flag should default to empty if it's not specified, it's a relatively easy fix.

@gmarek gmarek mentioned this issue May 23, 2016
Merged
@roberthbailey roberthbailey assigned gmarek and unassigned mqliang May 25, 2016
@gmarek
Copy link
Contributor

gmarek commented May 30, 2016

Fixed by #26054

@gmarek gmarek closed this as completed May 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmarek gmarek

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v1.3
Development

No branches or pull requests
5 participants
@gmarek @mikedanese @zmerlynn @bgrant0607 @mqliang