Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet container manager cgroup detection should error if cpu and memory differ #25909

Closed
derekwaynecarr opened this issue May 19, 2016 · 4 comments · Fixed by #25982 or #26586
Closed

kubelet container manager cgroup detection should error if cpu and memory differ #25909

derekwaynecarr opened this issue May 19, 2016 · 4 comments · Fixed by #25982 or #26586
Assignees
@derekwaynecarr
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Milestone
v1.3

Comments

@derekwaynecarr
Copy link
Member

kubelet container manager setup node routine should ensure that cpu and memory cgroups for container runtime are of the same value, and warn if they are equal to /.

For background, on systemd environments, the default unit file for docker has CPU and Memory accounting not enabled, so the /proc/.../cgroup file reports / as cpu cgroup.

#25907 (comment)
@derekwaynecarr
Copy link
Member Author

/cc @vishh - I will send a bug-fix for 1.3 for this in next couple days.

@derekwaynecarr derekwaynecarr added this to the v1.3 milestone May 19, 2016
@derekwaynecarr derekwaynecarr self-assigned this May 19, 2016
@derekwaynecarr
Copy link
Member Author

/cc @kubernetes/sig-node @kubernetes/rh-cluster-infra

@vishh
Copy link
Contributor

vishh commented May 19, 2016

Looking forward to the fix @derekwaynecarr

@dchen1107 dchen1107 added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels May 19, 2016
@derekwaynecarr derekwaynecarr mentioned this issue May 20, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue May 28, 2016
Merge pull request #25982 from derekwaynecarr/fix_stats
c730198 
Automatic merge from submit-queue

Fix system container detection in kubelet on systemd

```release-note
Fix system container detection in kubelet on systemd.

This fixed environments where CPU and Memory Accounting were not enabled on the unit 
that launched the kubelet or docker from reporting the root cgroup when 
monitoring usage stats for those components.
```

Fixes #25909

/cc @kubernetes/sig-node @kubernetes/rh-cluster-infra @vishh @dchen1107
@derekwaynecarr
Copy link
Member Author

The PR that fixes this issue was prematurely merged by the merge bot so re-opening.

@derekwaynecarr derekwaynecarr mentioned this issue May 31, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Jun 11, 2016
Merge pull request #26586 from derekwaynecarr/fix_runtime_stats
55dbcee 
Automatic merge from submit-queue

Fix system container detection

```release-note
Fix system container detection in kubelet on systemd.

This fixed environments where CPU and Memory Accounting were not enabled on the unit 
that launched the kubelet or docker from reporting the root cgroup when 
monitoring usage stats for those components.
```

Fixes #25909

/cc @vishh @ncdc @eparis @wojtek-t - this reverts the revert #26478

This should merge when node e2e setups were updated per #26289
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekwaynecarr derekwaynecarr

Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
v1.3
3 participants
@derekwaynecarr @vishh @dchen1107