+1. Does kubelet use these events?

Kubelet watches the event stream for Oom events, but never queries the storage. I'd like to just disable event storage completely for the Kubelet's cAdvisor, but that would be a regression if anyone was querying it through the cAdvisor endopoints. It is configurable from a flag though.

If a user wants that feature, they can always run cAdvisor in a DaemonSet :P

On Mon, Apr 25, 2016 at 4:18 PM, Tim St. Clair notifications@github.com
wrote:

Kubelet watches the event stream for Oom events, but never queries the
storage. I'd like to just disable event storage completely for the
Kubelet's cAdvisor, but that would be a regression if anyone was querying
it through the cAdvisor endopoints. It is configurable from a flag though.

—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly or view it on GitHub
#24698 (comment)

Not sure how cadvsior event stream works internally. After kubelet restarts, will it be able to get OOM events that happened in the past N minutes?

The event store is an in-memory data structure, so if kubelet restarts it would be lost anyway.

I assume cadvisor parses the kernel log again during startup. Is that not correct?

Ah, I understand your question. If it restarts, it will reparse the kernel log. The event stream is independent of the event store - so each event will be sent to the watchers and also (independently) added to the event store.

I see. Thanks for the clarification!

What is the status of this issue? We are past the feature freeze for 1.3 and this is still part of the milestone.

It depends on #25914, which has been LGTM'd for over a week... I'll get this reviewed now though, so it can go in as soon as the dependency is in.

Oops, that comment was referring to the PR which addresses this (#24771).

Just as a general note, I would still like to off-load events entirely out of the mainline path.

/cc @kubernetes/sig-scalability

@timothysc - I don't understand your comment. This issue refers to events generated by cAdvisor from scanning the kernel logs. Were you referring to the same events?

@timstclair ohh... I was referring to kubernetes events.

Ok, makes sense. This should have no effect on kubernetes events.