Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit flake: pkg/client/record #23610

Closed
pwittrock opened this issue Mar 29, 2016 · 5 comments
Closed

unit flake: pkg/client/record #23610

pwittrock opened this issue Mar 29, 2016 · 5 comments
Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@pwittrock
Copy link
Member

pkg/client/record failed, but afaict didn't give useful output

http://pr-test.k8s.io/23285/kubernetes-pull-test-unit-integration/19655/

ok k8s.io/kubernetes/pkg/client/leaderelection 1.110s
FAIL k8s.io/kubernetes/pkg/client/record 2.569s
ok k8s.io/kubernetes/pkg/client/restclient 1.282s
@pwittrock pwittrock added the kind/flake Categorizes issue or PR as related to a flaky test. label Mar 29, 2016
@pwittrock pwittrock mentioned this issue Mar 29, 2016
Merged
@Q-Lee
Copy link
Contributor

Q-Lee commented Mar 29, 2016

Ditto here: #23512

http://pr-test.k8s.io/23512/kubernetes-pull-test-unit-integration/19644/

ok k8s.io/kubernetes/pkg/client/leaderelection 1.059s
FAIL k8s.io/kubernetes/pkg/client/record 2.588s
ok k8s.io/kubernetes/pkg/client/restclient 1.251s

@Q-Lee Q-Lee mentioned this issue Mar 29, 2016
Merged
@a-robinson a-robinson added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 30, 2016
@a-robinson
Copy link
Contributor

And again today:
https://cloud.google.com/console/storage/kubernetes-jenkins/logs/kubernetes-test-go/10329/

Why is there no output from the failed test? @spxtr @krousey, have any idea?

@spxtr
Copy link
Contributor

spxtr commented Mar 30, 2016

There is output, it's in artifacts/blablabla.stdout.

WARNING: DATA RACE
Write by goroutine 23:
  testing.(*common).log()
      /usr/local/go/src/testing/testing.go:353 +0x1e6
  testing.(*common).Logf()
      /usr/local/go/src/testing/testing.go:366 +0x82
  testing.(*common).Logf-fm()
      /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/record/event_test.go:351 +0x5f
  k8s.io/kubernetes/pkg/client/record.(*eventBroadcasterImpl).StartLogging.func1()
      /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/record/event.go:216 +0x2a7
  k8s.io/kubernetes/pkg/client/record.(*eventBroadcasterImpl).StartEventWatcher.func1()
      /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/record/event.go:237 +0x14e

Previous read by main goroutine:
  runtime.convT2E()
      /usr/local/go/src/runtime/iface.go:128 +0x0
  testing.(*T).report()
      /usr/local/go/src/testing/testing.go:538 +0xa18
  testing.RunTests()
      /usr/local/go/src/testing/testing.go:591 +0xbdf
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:515 +0x11d
  main.main()
      k8s.io/kubernetes/pkg/client/record/_test/_testmain.go:70 +0x210

Goroutine 23 (running) created at:
  k8s.io/kubernetes/pkg/client/record.(*eventBroadcasterImpl).StartEventWatcher()
      /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/record/event.go:239 +0x8f
  k8s.io/kubernetes/pkg/client/record.(*eventBroadcasterImpl).StartLogging()
      /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/record/event.go:217 +0xa5
  k8s.io/kubernetes/pkg/client/record.TestEventf()
      /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/pkg/client/record/event_test.go:351 +0x3034
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:473 +0xdc

Looks like the same issue as #23372. @wojtek-t mind taking a look?

@a-robinson
Copy link
Contributor

Well that's certainly useful to know, thanks!

@wojtek-t
Copy link
Member

Duplicate of #23533

@spxtr - I'm in US now, so I will not find time to look into it within a week.
Note - that there is comment why it is failing (which is different than #23372 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@a-robinson @spxtr @pwittrock @wojtek-t @Q-Lee