Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Feature: CA integration #23482

Closed
justinsb opened this issue Mar 25, 2016 · 11 comments
Closed

AWS Feature: CA integration #23482

justinsb opened this issue Mar 25, 2016 · 11 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. milestone/removed priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@justinsb
Copy link
Member

AWS has limited CA support, and there is also LetsEncrypt.

Services (or ingress points) should declare that they want a certificate, and we should be able to automatically provision (& renew) them.

It is unclear whether there is value in the Amazon service, given LetsEncrypt exists.

@justinsb justinsb added area/platform/aws kind/feature Categorizes issue or PR as related to a new feature. labels Mar 25, 2016
@justinsb justinsb added this to the v1.3 milestone Mar 25, 2016
@justinsb justinsb added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Mar 25, 2016
@therc
Copy link
Member

therc commented Mar 28, 2016

We're using the new Certificate Manager and #23495 does the trick if you create a wildcard certificate in advance. Wildcards are probably a better match for now, since you can have only twenty certificates, each with up to ten fully qualified domains, plus there's an yearly limit, too, so I'm reluctant to have the controller manager burn through such a scarce resource, especially if there are bugs or misconfigurations. An improvement might be to have the controller look up certificates by host/domain name, instead of having to hardcode the ARN.

@bprashanth
Copy link
Contributor

See #19899 for lets encrypt integration. Having at least one way to get/renew real certs cross-platform makes sense, that's not to say we can't support multiple platform-specific ways.

I imagine that if a user creats something like:

apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  name: test
spec:
  tls:
  - hosts:
    - foo.bar.com
    - foobar.bar.com
    secretName: ""
  backend:
    serviceName: echoserver-https
    servicePort: 80

A cluster wide cert controller (or a cert sidecar in the ingress controller) would notice this, get the certs and populate the secret field. Only then would the haproxy/nginx/cloudlb pick the Ingress up.

@bprashanth
Copy link
Contributor

Taking this a step further, we could install admission controllers that never allowed non-https Ingress (like a cluster wide HSTS flag). Either a real (letsencrypt style), internal (pki server signed) or self signed cert is required.

@justinsb
Copy link
Member Author

justinsb commented Jun 3, 2016

Moving to 1.4; we can likely do this outside of core (e.g. kube-lego), so we won't do anything in 1.3 I believe

@justinsb justinsb modified the milestones: v1.4, v1.3 Jun 3, 2016
@goltermann goltermann modified the milestones: v1.5, v1.4 Sep 6, 2016
@justinsb justinsb self-assigned this Nov 15, 2016
@dims
Copy link
Member

dims commented Nov 15, 2016

@justinsb ok to move this to 1.6? please holler if not appropriate

@dims dims modified the milestones: v1.6, v1.5 Nov 15, 2016
@ethernetdan
Copy link
Contributor

Moving to 1.7 as late to happen in 1.6. Feel free to switch back if this is incorrect.

@ethernetdan ethernetdan modified the milestones: v1.7, v1.6 Mar 13, 2017
@marun
Copy link
Contributor

marun commented Jun 14, 2017

Given that there has been no activity in v1.7, moving to v1.8.

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Removed

@justinsb

Important:
This issue was missing labels required for the v1.8 milestone for more than 7 days:

priority: Must specify exactly one of [priority/critical-urgent, priority/important-longterm, priority/important-soon].

Removing it from the milestone.

Additional instructions available here The commands available for adding these labels are documented here

@k8s-github-robot k8s-github-robot removed this from the v1.8 milestone Sep 9, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 5, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 9, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. milestone/removed priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests