Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'kubectl get rc' for rcs with more than one container #22742

Closed
jmastr opened this issue Mar 9, 2016 · 15 comments
Closed

Fix 'kubectl get rc' for rcs with more than one container #22742

jmastr opened this issue Mar 9, 2016 · 15 comments
Assignees
@adohe-zz
Labels
area/kubectl priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone
v1.2

Comments

@jmastr
Copy link

jmastr commented Mar 9, 2016

Commit 53d4b15 moved columns into wide option to make result more readable. However, the patch did not consider more than one container in the rc, e.g.:

NAME              DESIRED          CURRENT                                                               AGE
kube-dns-v10      1                1                                                                     5d
                  kube2sky         gcr.io/google_containers/kube2sky:1.12                                          
                  skydns           gcr.io/google_containers/skydns:2015-10-13-8c72f8c                              
                  healthz          gcr.io/google_containers/exechealthz:1.0

The desired output shall be probably something like that:

NAME              DESIRED          CURRENT                                                               AGE
kube-dns-v10      1                1                                                                     5d

and the remaining information in -owide.
@adohe-zz
Copy link

adohe-zz commented Mar 9, 2016

@jmastr IIUC you want to move the containers display row to -o wide option, I am not sure whether we should do this, if we do this with rc, we have to do same thing with rs, ds etc, in order to keep consistence. @kubernetes/kubectl

@jmastr
Copy link
Author

jmastr commented Mar 9, 2016

@adohe No, that was only my guess. I would like to revert commit 53d4b15. This also should keep the consistency...

@dchen1107
Copy link
Member

commit 53d4b15 is in 1.2 release branch. I marked this as P0 and 1.2 milestone for now. We need to make the decision asap.

@dchen1107 dchen1107 added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 9, 2016
@dchen1107 dchen1107 added this to the v1.2 milestone Mar 9, 2016
@bgrant0607
Copy link
Member

We shouldn't revert the change. We should move the other containers to the wide output.

In general, kubectl get output should NEVER be multi-line.

@bgrant0607
Copy link
Member

Could you please work on this, @adohe ?

@bgrant0607
Copy link
Member

Personally, I think we could omit all of the container names.

@bgrant0607
Copy link
Member

And probably repo names

@jmastr
Copy link
Author

jmastr commented Mar 9, 2016

Having the container names was what I wanted in the first place. It gives a
nice overview. Good for a huge cluster.

Please do not remove that behavior...

@adohe-zz
Copy link

@bgrant0607 sure I will work on this.

@bgrant0607
Copy link
Member

@adohe Thanks! Keep both container names and images for now. For multi-container pods, the output will be long, but we can improve the output more in 1.3.

@bgrant0607
Copy link
Member

That is, keep them in the wide output

@bgrant0607
Copy link
Member

@adohe How is it going? We need to get this fix in soon in order to make the next beta release. Do you need help?

cc @janetkuo @madhusudancs

@bgrant0607
Copy link
Member

cc @Kargakis @soltysh

@adohe-zz
Copy link

@bgrant0607 I have opened a PR already #22772

@bgrant0607
Copy link
Member

@adohe Sorry. I didn't see it, because it didn't reference this issue.

@adohe-zz adohe-zz mentioned this issue Mar 11, 2016
Merged
openshift-publish-robot pushed a commit to openshift/kubernetes that referenced this issue Aug 7, 2019
@k8s-publishing-bot
Merge pull request kubernetes#22742 from ingvagabund/release-3.11-bac…
a65abba 
…kport-77069

Bug 1703512: [release-3.11] backport kubernetes#77069

Origin-commit: 3f341cdd10f7d1a5d3935428a5b2e8df667eccd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adohe-zz adohe-zz

Labels
area/kubectl priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
v1.2
Development

No branches or pull requests
4 participants
@adohe-zz @bgrant0607 @dchen1107 @jmastr