make test consistently fails on plugin/pkg/auth/authenticator/token/oidc
#20242
Labels
Comments
|
@timothysc Thanks for reporting. |
|
Maybe something to do with these test's use of Wasn't able to replicate timeouts like in the pasted code, but need to tweak the tests before running $ git diff oidc_test.go
diff --git a/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go b/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go
index 348ae19..528c68c 100644
--- a/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go
+++ b/plugin/pkg/auth/authenticator/token/oidc/oidc_test.go
@@ -202,11 +202,14 @@ func TestOIDCDiscoveryNoKeyEndpoint(t *testing.T) {
var err error
expectErr := fmt.Errorf("OIDC provider must provide 'jwks_uri' for public key discovery")
- cert := path.Join(os.TempDir(), "oidc-cert")
- key := path.Join(os.TempDir(), "oidc-key")
+ tempdir, err := ioutil.TempDir("", "")
+ if err != nil {
+ t.Fatal(err)
+ }
+ defer os.RemoveAll(tempdir)
- defer os.Remove(cert)
- defer os.Remove(key)
+ cert := path.Join(tempdir, "oidc-cert")
+ key := path.Join(tempdir, "oidc-key")
generateSelfSignedCert(t, "127.0.0.1", cert, key) |
|
repro on f23 w/go1.5.3 is 100% |
|
@timothysc by f23 you mean fedora 23? Odd, that's what I'm using. I'll try to parse the stack trace and figure out what's going on. |
|
@timothysc What's the command you use to run the test? |
|
@yifan-gu |
|
These pass for me when running through the Makefile. Logs of a full |
|
@ericchiang - what version of golang are you running? |
|
@timothysc sorry should have specified that |
|
Hitting this on two different Fedora 23 machines consistently... golang-1.5.3-1.fc23.x86_64 |
|
@dcbw does the error look the same as the original comment? Can you paste the output of Are you installing Go via dnf or through the binary distributions from golang.org? |
|
@ericchiang it's a similar error, though not exactly the same. But perhaps similar enough to be the same root cause? The last test eventually times out. I'm installing Go via dnf; since bare 'go' and 'godep' commands don't work (they don't use the environment set up by make and the hack/* scripts) I'm using this instead. $ make test WHAT=plugin/pkg/auth/authenticator/token/oidc GOFLAGS=-v |
|
@dcbw ah I'm installing via the binary distros. Maybe the dnf installs are slightly different? Will investigate. |
|
@ericchiang full failure is at http://people.redhat.com/dcbw/oidc.log |
|
@ericchiang the test hangs on client.Close() for the last testcase: |
|
@ericchiang I lied; it's actually hanging on the httptest.Server Close() from the defer srv.Close(). Trying to track that down... |
|
Either way, maybe a lack of dial timeouts in the transport might be causing the hang? |
|
@ericchiang looks like it's actually golang/go#12262 and there are a couple other places in oidc_test.go that comment out srv.Close() due to this. Doing that fixes it for me too... |
|
@ericchiang the original bug is probably different, so I'll drop off this report and handle this in #20752 instead. |
|
I have not seen this in a long time, closing. |
openshift-publish-robot
pushed a commit
to openshift/kubernetes
that referenced
this issue
Jul 12, 2018
upstream machinery picks Origin-commit: ea877acae817559712c8d42ef2c5caee880d319d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue has existed for some time now on my f23 env.
https://paste.fedoraproject.org/315507/14539328/
go1.5.3
/cc @yifan-gu @liggitt (also seen on latest origin rebase as well)
The text was updated successfully, but these errors were encountered: