Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider Exposing Pods in the Kubelet REST API #1934

Closed
vmarmol opened this issue Oct 21, 2014 · 6 comments
Closed

Consider Exposing Pods in the Kubelet REST API #1934

vmarmol opened this issue Oct 21, 2014 · 6 comments
Assignees
@dchen1107
Labels
area/kubelet area/kubelet-api sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@vmarmol
Copy link
Contributor

vmarmol commented Oct 21, 2014

For monitoring purposes it will be extremely useful to gather what pods are running on a node and those pod's labels. I believe that information is already available on the Kubelet. This issue is about exposing this information in the Kubelet's REST API.

cc @dchen1107
@dchen1107
Copy link
Member

We talked about this before. With the latest v1beta3 related change, kubelet now reads BoundPods from etcd instead of ContainerManifestList. So now we can expose pods in the kubelet API.

But BoundPod doesn't have labels included. What are the usecases for pod's label? @bgrant0607 @smarterclayton

@bgrant0607
Copy link
Member

We need to propagate labels to logging, monitoring, containers, etc.
#560, #386

@bgrant0607
Copy link
Member

BoundPod does have labels in v1beta3

@smarterclayton
Copy link
Contributor

It does but I specifically excluded it in the default conversion (to avoid leaking info until we decide to do it).

----- Original Message -----

BoundPod does have labels in v1beta3

Reply to this email directly or view it on GitHub:
#1934 (comment)

@dchen1107 dchen1107 self-assigned this Oct 21, 2014
@dchen1107
Copy link
Member

Cool, I will expose API for cAdvisor to get pods on Node. Then labels later.

@dchen1107 dchen1107 added this to the v0.7 milestone Oct 22, 2014
@dchen1107 dchen1107 mentioned this issue Oct 22, 2014
Closed
@dchen1107
Copy link
Member

Fixed it via #1964

@dchen1107 dchen1107 added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchen1107 dchen1107

Labels
area/kubelet area/kubelet-api sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vmarmol @smarterclayton @bgrant0607 @dchen1107