Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Namespaces should delete fast enough is flaky in parallel #19026

Closed
ikehz opened this issue Dec 22, 2015 · 4 comments
Closed

Namespaces should delete fast enough is flaky in parallel #19026

ikehz opened this issue Dec 22, 2015 · 4 comments
Assignees
@derekwaynecarr
Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@ikehz
Copy link
Contributor

ikehz commented Dec 22, 2015

Namespaces should delete fast enough (90 percent of 100 namespaces in 150 seconds) is flaky in parallel. It was marked as flaky-in-parallel in #13810.

It should be deflaked. Or, if they shouldn't be run in parallel, add the [Disruptive] or [Serial] label to the test.
@ikehz ikehz added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. team/control-plane kind/flake Categorizes issue or PR as related to a flaky test. labels Dec 22, 2015
@mikedanese mikedanese assigned davidopp and unassigned mikedanese Dec 22, 2015
@mikedanese
Copy link
Member

@davidopp I can look at this if you like. I have 2 other flakes that I am assigned to at the moment though and I'm not familiar with the test.

cc @derekwaynecarr

@davidopp davidopp assigned derekwaynecarr and unassigned davidopp Jan 10, 2016
@davidopp
Copy link
Member

@derekwaynecarr would you mind taking a look at this? I read through the chain #13810 -> #7372 -> #18290, but it looks like #18290 was merged before this issue was opened, so presumably it's not fixed by #18290.

@derekwaynecarr
Copy link
Member

I am investigating this now. Will update if I find anything obvious.

@derekwaynecarr
Copy link
Member

I am inclined to mark this test [Serial] and determine if the flakes are resolved. The test is much more write-intensive than other tests (200 namespaces, service accounts, etc.) and it deletes all of the above. I think we can evaluate running this parallel when more resources are being deleted in bulk collection calls.

@derekwaynecarr derekwaynecarr mentioned this issue Jan 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekwaynecarr derekwaynecarr

Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ikehz @mikedanese @derekwaynecarr @davidopp