Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis example: Missing sentinel.py #17938

Closed
palonsoro opened this issue Nov 30, 2015 · 2 comments
Closed

Redis example: Missing sentinel.py #17938

palonsoro opened this issue Nov 30, 2015 · 2 comments

Comments

@palonsoro
Copy link

Dockerfile at redis example refers to a sentinel.py that is missing. Where is that file? Is it required?

@palonsoro
Copy link
Author

If I pull the image from docker hub and inspect it, I see the following contents:

import json
import sys

data = json.load(sys.stdin)

if data and "endpoints" in data and len(data["endpoints"]) > 0:
  host = data["endpoints"][0].split(":")[0]
else:
  host = "localhost"

print "sentinel monitor mymaster %s 6379 2" % host
print "sentinel down-after-milliseconds mymaster 60000"
print "sentinel failover-timeout mymaster 180000"
print "sentinel parallel-syncs mymaster 1"

These options seem to be set in this snippet of run.sh:

sentinel_conf=sentinel.conf

echo "sentinel monitor mymaster ${master} 6379 2" > ${sentinel_conf}
echo "sentinel down-after-milliseconds mymaster 60000" >> ${sentinel_conf}
echo "sentinel failover-timeout mymaster 180000" >> ${sentinel_conf}
echo "sentinel parallel-syncs mymaster 1" >> ${sentinel_conf}

So, this file seems to be no longer necessary. Even the Python package itself may also not be necessary, am I right?

@bgrant0607
Copy link
Member

Fixed by #18141 and #18252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants