Skip to content

Examples should demonstrate best practices #1603

Closed
@bgrant0607

Description

redis-master doesn't demonstrate best practices, with respect to Kubernetes and Redis.

Kubernetes: redis-master is a naked pod with no replication controller. If the node dies, the service is toast.

Redis: IIUC, redis-master doesn't take advantage of Redis's HA features, such as sentinel

Persistence is more questionable, but that's another feature we could incorporate into the example, esp. once we support durable data.

We should also remove hostPort from examples

Metadata

Assignees

No one assigned

    Labels

    area/examplekind/cleanupCategorizes issue or PR as related to cleaning up code, process, or technical debt.kind/documentationCategorizes issue or PR as related to documentation.priority/backlogHigher priority than priority/awaiting-more-evidence.sig/api-machineryCategorizes an issue or PR as relevant to SIG API Machinery.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions