Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment: requirements for graduation to "beta" #15313

Closed
bgrant0607 opened this issue Oct 8, 2015 · 16 comments · Fixed by #22724
Closed

Deployment: requirements for graduation to "beta" #15313

bgrant0607 opened this issue Oct 8, 2015 · 16 comments · Fixed by #22724
Assignees
Labels
area/api Indicates an issue on api area. area/app-lifecycle priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@bgrant0607
Copy link
Member

Before Deployment graduates from experimental:

  • It needs to implement a status subresource
  • It needs to adopt the more general selector, as discussed in Generalize label selectors #341. This would be very hard to change later.
  • The name needs to be finalized

cc @nikhiljindal @ironcladlou @ghodss

@bgrant0607 bgrant0607 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/api Indicates an issue on api area. area/app-lifecycle team/ux labels Oct 8, 2015
@bgrant0607 bgrant0607 added this to the v1.2-candidate milestone Oct 13, 2015
@erictune
Copy link
Member

IIUC, These are requirements for Deployment to graduate to default-on, a.k.a "beta".

@erictune erictune changed the title Deployment graduation requirements Deployment: requirements for graduation to "beta" Oct 20, 2015
@nikhiljindal
Copy link
Contributor

IIUC. these are requirements for enabling deployments by default on HEAD as well, right?
cc @lavalamp

@lavalamp
Copy link
Member

@nikhiljindal No-- IMO we can and should turn it on on HEAD as long as it's not destabilizing anything.

@lavalamp
Copy link
Member

Also the e2e tests need to auto-discover whether the API is on and short-circuit if not, so that there's only one knob to flip.

@bgrant0607
Copy link
Member Author

Copying note from https://github.com/kubernetes/kubernetes/pull/19686/files#r51005929

We should change DefaultDeploymentUniqueLabelKey to "pod-template-hash" (all lowercase, no prefix).

@bgrant0607
Copy link
Member Author

We should copy all Deployment annotations to the RC of the latest revision in order to capture them in the revision history.

@bgrant0607
Copy link
Member Author

Other issues that need to be resolved:
#20290
#19111
#17164
#18078
#16737
#3024
#20087

The API also needs to be enabled by default.

@bgrant0607
Copy link
Member Author

In flight:

Not done yet:

  • Doc updates

Not going to make it in 1.2:

  • Perm-fail and kubectl rollout retry
  • kubectl set image
  • watch rollout status in kubectl
  • kubectl set env, commands, args

@bgrant0607
Copy link
Member Author

Specifically, the user guide needs to be updated.
https://github.com/kubernetes/kubernetes/blob/master/docs/user-guide/deployments.md

@janetkuo
Copy link
Member

janetkuo commented Feb 2, 2016

From @roberthbailey: We should move it to beta soon so that we can start testing it in the gke e2e tests at head.

@janetkuo
Copy link
Member

janetkuo commented Feb 2, 2016

We should copy all Deployment annotations to the RC of the latest revision in order to capture them in the revision history.

This feature is added in #20035

@janetkuo
Copy link
Member

janetkuo commented Feb 2, 2016

Filed #20517 to enable deployments by default, enable deployments in kubectl run, and update related docs/scripts.

@madhusudancs
Copy link
Contributor

Remove the defaulting behavior that defaults RC labels and Deployment selector to pod template labels in order to be consistent with Job's defaulting behavior.

cc @bgrant0607 @janetkuo @erictune

@bgrant0607
Copy link
Member Author

Note that we're waiting for the API to stabilize before enabling Deployment by default: label selector (change to new selector and ReplicaSet), MinReadySeconds (move to DeploymentSpec), uniqueLabelKey (rename to templateHashLabelKey), and the defaulting behavior (mentioned above) at least need to be in their intended states for v1beta1.

@bgrant0607
Copy link
Member Author

We've decided not to change the selector and label defaulting behavior in v1beta1.

We're still waiting on scale, stop, and some replicaset features.

I'd like to enable scaling of paused deployments, but we won't block on that.

@bgrant0607 bgrant0607 assigned madhusudancs and unassigned janetkuo Mar 1, 2016
@bgrant0607
Copy link
Member Author

Just waiting on /scale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates an issue on api area. area/app-lifecycle priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
7 participants