-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deployment: requirements for graduation to "beta" #15313
Comments
IIUC, These are requirements for Deployment to graduate to default-on, a.k.a "beta". |
IIUC. these are requirements for enabling deployments by default on HEAD as well, right? |
@nikhiljindal No-- IMO we can and should turn it on on HEAD as long as it's not destabilizing anything. |
Also the e2e tests need to auto-discover whether the API is on and short-circuit if not, so that there's only one knob to flip. |
Copying note from https://github.com/kubernetes/kubernetes/pull/19686/files#r51005929 We should change DefaultDeploymentUniqueLabelKey to "pod-template-hash" (all lowercase, no prefix). |
We should copy all Deployment annotations to the RC of the latest revision in order to capture them in the revision history. |
In flight:
Not done yet:
Not going to make it in 1.2:
|
Specifically, the user guide needs to be updated. |
From @roberthbailey: We should move it to beta soon so that we can start testing it in the gke e2e tests at head. |
This feature is added in #20035 |
Filed #20517 to enable deployments by default, enable deployments in |
Remove the defaulting behavior that defaults RC labels and Deployment selector to pod template labels in order to be consistent with Job's defaulting behavior. |
Note that we're waiting for the API to stabilize before enabling Deployment by default: label selector (change to new selector and ReplicaSet), MinReadySeconds (move to DeploymentSpec), uniqueLabelKey (rename to templateHashLabelKey), and the defaulting behavior (mentioned above) at least need to be in their intended states for v1beta1. |
We've decided not to change the selector and label defaulting behavior in v1beta1. We're still waiting on scale, stop, and some replicaset features. I'd like to enable scaling of paused deployments, but we won't block on that. |
Just waiting on /scale. |
Before Deployment graduates from experimental:
cc @nikhiljindal @ironcladlou @ghodss
The text was updated successfully, but these errors were encountered: