Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove HostPort from most examples #1487

Closed
thockin opened this issue Sep 29, 2014 · 7 comments
Closed

Remove HostPort from most examples #1487

thockin opened this issue Sep 29, 2014 · 7 comments
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@thockin
Copy link
Member

thockin commented Sep 29, 2014

I think it is almost never needed, and causes trouble.
@dchen1107 dchen1107 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 29, 2014
@jbeda jbeda added help wanted priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 29, 2014
@rgooch
Copy link

rgooch commented Oct 3, 2014

I'm taking a look.

@bgrant0607 bgrant0607 added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 4, 2014
@bgrant0607 bgrant0607 added this to the v1.0 milestone Oct 4, 2014
@bgrant0607
Copy link
Member

Don't forget the examples in api/examples.

We'll need to convert all examples to v1beta3: #3671. We could do it then.

@bgrant0607
Copy link
Member

cc @rsokolowski

@bgrant0607 bgrant0607 mentioned this issue Feb 5, 2015
Closed
@bgrant0607
Copy link
Member

Cupe of #1603

@bgrant0607 bgrant0607 mentioned this issue Feb 18, 2015
Merged
@erictune erictune mentioned this issue Feb 19, 2015
Merged
@bgrant0607 bgrant0607 mentioned this issue Apr 23, 2015
Closed
@mikedanese
Copy link
Member 

examples/meteor/meteor-controller.json:29:                "hostPort": 80,
examples/celery-rabbitmq/flower-controller.yaml:22:          hostPort: 5555
examples/celery-rabbitmq/README.md:247:          hostPort: 5555
examples/spark/spark-worker-controller.json:29:                "hostPort": 8888,
examples/storm/storm-worker-controller.json:29:                "hostPort": 6700,
examples/storm/storm-worker-controller.json:33:                "hostPort": 6701,
examples/storm/storm-worker-controller.json:37:                "hostPort": 6702,
examples/storm/storm-worker-controller.json:41:                "hostPort": 6703,

@bgrant0607 bgrant0607 reopened this Jul 18, 2015
@bgrant0607 bgrant0607 added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed help-wanted kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 18, 2015
@mikedanese
Copy link
Member

the examples/meteor and examples/celery-rabbitmq have been fixed up because the hostPort was unused in the example but AFAIK the spark and storm examples rely on hostPort

This was referenced Jul 18, 2015
Merged
Merged
@bgrant0607
Copy link
Member

Thanks. IIRC hostPort was added to the celery example in order to make the flower admin UI visible. A link to instructions about how to use the proxy might be called for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jbeda @mikedanese @thockin @bgrant0607 @dchen1107 @rgooch