Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Rolling-Updates to support updating image with multi-container pods #13483

Closed
mingfang opened this issue Sep 2, 2015 · 8 comments
Closed

Enhance Rolling-Updates to support updating image with multi-container pods #13483

mingfang opened this issue Sep 2, 2015 · 8 comments
Labels
area/app-lifecycle area/kubectl priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@mingfang
Copy link

mingfang commented Sep 2, 2015

As of 1.0.3, rolling-update with --image does not work when pod has multiple containers.
This is the error message
error: Image update is not supported for multi-container pods
@janetkuo
Copy link
Member

janetkuo commented Sep 3, 2015

A PR is underway #9868

@bgrant0607-nocc bgrant0607-nocc added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed kind/friction labels Sep 4, 2015
@coleca
Copy link

coleca commented Oct 2, 2015

Is this planned for 1.1? It would be really helpful to use for pods using the sidecar patterns in a CI environment.

@janetkuo
Copy link
Member

@coleca It's not planned for 1.1.

@mingfang
Copy link
Author

PR #9868 appears to not make any progress.
Being able to do rolling updates is key to our team's ability to use kubernetes.
Do we know what ballpark timeframe to expect this feature to be released?

@janetkuo
Copy link
Member

cc @bgrant0607

@bgrant0607
Copy link
Member

The author of #9868 never addressed review feedback and never responded to requests to rebase. It's been inactive since July. I just closed it.

kubectl rolling-update can be used for multi-container pods. It's only the --image convenience feature that doesn't support it.

We're working on a server-side implementation of rolling update. It will be possible to enable the experimental API in 1.1:
https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/deployment.md

cc @nikhiljindal @ironcladlou

@janetkuo janetkuo mentioned this issue Oct 21, 2015
Closed
@bgrant0607
Copy link
Member

@brendandburns, would you be interested in taking this on?

@bgrant0607 bgrant0607 mentioned this issue Oct 21, 2015
Merged
@munnerz munnerz mentioned this issue Nov 11, 2015
Merged
@bgrant0607
Copy link
Member

#17111 has merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/app-lifecycle area/kubectl priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@coleca @mingfang @janetkuo @bgrant0607 @mwielgus @bgrant0607-nocc