Description
/sig autoscaling
/cc @kubernetes/sig-autoscaling-misc
What
HPA's development has not been active recently.
It causes many PRs to struggle to get reviews, including some KEPs.
Essentially, this is the problem of lacking approvers in HPA.
Context (AFAIK)
Currently, @mwielgus is the only approver, but already left the sig-autoscaling chair, and I'm not sure if they're still willing to help in reviewing.
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/podautoscaler/OWNERS#L7
I know the step down doesn't always mean a stop working on things, but, in this case, actually the last review from them was more than 1 year ago.
https://github.com/kubernetes/kubernetes/pulls?q=is%3Apr+reviewed-by%3Amwielgus+is%3Aclosed
There are some minor changes made in HPA though, all of them are approved by someone else (root approvers), not stamps from sig-autoscaling.
https://github.com/kubernetes/kubernetes/commits/master/pkg/controller/podautoscaler
Also, @gjtempleton is trying to take over the position, and he's (only) a reviewer (not yet approver) apart from @mwielgus now.
Proposal
We're trapped in a vicious cycle; HPA development is not active because of the lack of reviewers/approvers, and no reviewer is newly born because HPA development is not active.
There's (probably, AFAIK) no other active person who is eligible for the reviewer/approver of HPA based on the official criteria.
But, we shouldn't keep the current situation, and I'd propose having some volunteers to join reviewers/approvers to break through (even if they're not officially eligible).
Regarding the approver, I cannot come up with any idea other than asking @gjtempleton to be an approver and start approving some PRs. (... I know they're also busy though)
Also, when I was doing the container-based HPA enhancement, I remember @pbarker also helped reviewing a lot, might be a good idea to ask them to join the reviewer list. (PRs, reviews) I can also help in being a reviewer too. (PRs, reviews)
Activity