Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPA development is not active #128948

Open
sanposhiho opened this issue Nov 23, 2024 · 7 comments
Open

HPA development is not active #128948

sanposhiho opened this issue Nov 23, 2024 · 7 comments
Labels
needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.

Comments

@sanposhiho
Copy link
Member

/sig autoscaling
/cc @kubernetes/sig-autoscaling-misc

What

HPA's development has not been active recently.
It causes many PRs to struggle to get reviews, including some KEPs.
Essentially, this is the problem of lacking approvers in HPA.

Context (AFAIK)

Currently, @mwielgus is the only approver, but already left the sig-autoscaling chair, and I'm not sure if they're still willing to help in reviewing.
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/podautoscaler/OWNERS#L7
I know the step down doesn't always mean a stop working on things, but, in this case, actually the last review from them was more than 1 year ago.
https://github.com/kubernetes/kubernetes/pulls?q=is%3Apr+reviewed-by%3Amwielgus+is%3Aclosed

There are some minor changes made in HPA though, all of them are approved by someone else (root approvers), not stamps from sig-autoscaling.
https://github.com/kubernetes/kubernetes/commits/master/pkg/controller/podautoscaler

Also, @gjtempleton is trying to take over the position, and he's (only) a reviewer (not yet approver) apart from @mwielgus now.

Proposal

We're trapped in a vicious cycle; HPA development is not active because of the lack of reviewers/approvers, and no reviewer is newly born because HPA development is not active.

There's (probably, AFAIK) no other active person who is eligible for the reviewer/approver of HPA based on the official criteria.
But, we shouldn't keep the current situation, and I'd propose having some volunteers to join reviewers/approvers to break through (even if they're not officially eligible).

Regarding the approver, I cannot come up with any idea other than asking @gjtempleton to be an approver and start approving some PRs. (... I know they're also busy though)
Also, when I was doing the container-based HPA enhancement, I remember @pbarker also helped reviewing a lot, might be a good idea to ask them to join the reviewer list. (PRs, reviews) I can also help in being a reviewer too. (PRs, reviews)
@k8s-ci-robot k8s-ci-robot added sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 23, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adrianmoisey
Copy link
Member

This problem also applies to the VPA.
Myself (and a small group of others, @omerap12 being one of them) are trying to contribute to the VPA, in order to climb the ranks to become approvers. But it is catch 22, since the current approvers are very busy and can't dedicate much time to review.
For the moment we try review amongst ourselves, getting PRs into a good state. Then we batch up a bunch of PRs and ask the approvers to approve. This is mostly working well, but will take some time before we get to the point where we have more approvers.

I'm happy to turn my attention to the HPA too, but for now all I can offer is code review, no approval.

@omerap12
Copy link
Member

This problem also applies to the VPA. Myself (and a small group of others, @omerap12 being one of them) are trying to contribute to the VPA, in order to climb the ranks to become approvers. But it is catch 22, since the current approvers are very busy and can't dedicate much time to review. For the moment we try review amongst ourselves, getting PRs into a good state. Then we batch up a bunch of PRs and ask the approvers to approve. This is mostly working well, but will take some time before we get to the point where we have more approvers.

I'm happy to turn my attention to the HPA too, but for now all I can offer is code review, no approval.

I agree with the above. I'm also willing to help, but I'm not very familiar with the HPA codebase yet (though I'd like to dive into it).

@DP19
Copy link
Contributor

DP19 commented Nov 25, 2024

I can also volunteer some time here; I've become pretty familiar with the code when comparing it against a GKE issue we ran into here and also working on this bug (that's still waiting to be approved like you've mentioned)

@wzshiming
Copy link
Member

This problem also bothered me, and I tried to push the from/to 0 feature of HPV but didn't get much progress

@soltysh
Copy link
Contributor

soltysh commented Nov 28, 2024

This was brought to my attention as one of the steering members overlooking sig-autoscaling. I've started a conversation with current and past leads to ensure we can move forward and get us all in a situation that will ensure the SIG has the necessary power to approve code changes.

@sftim
Copy link
Contributor

sftim commented Dec 10, 2024

Is this possibly also relevant to SIG ContribEx?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@soltysh @adrianmoisey @wzshiming @k8s-ci-robot @DP19 @sftim @sanposhiho @omerap12