Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The update-vendor.sh is broken with GOPROXY=direct #127623

Closed
stlaz opened this issue Sep 25, 2024 · 11 comments
Closed

The update-vendor.sh is broken with GOPROXY=direct #127623

stlaz opened this issue Sep 25, 2024 · 11 comments
Labels
area/code-organization Issues or PRs related to kubernetes code organization kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Milestone
v1.32

Comments

@stlaz
Copy link
Member

stlaz commented Sep 25, 2024

What happened?

#126799 seems to have broken the vendor by adding a transitive dependency at a version that no longer exists

What did you expect to happen?

./hack/update-vendor.sh should not fail

How can we reproduce it (as minimally and precisely as possible)?

Run ./hack/update-vendor.sh with an emtpy _output/ dir

Anything else we need to know?

https://github.com/microsoft/hcsshim/blob/main/go.mod seems to be fixing the dependency but does not appear to be in any released version of microsoft/hcsshim

Snip from ./hack/update-vendor.sh logs:

+ errs=()
+ kube::util::read-array errs
+ [[ -z errs ]]
++ declare -p errs
++ go list -e -tags=tools -json all
++ jq -r '.Error.Err | select( . != null )'
++ grep -v 'is a program, not an importable package'
+ [[ -n declare -a errs=() ]]
+ declare -p errs
+ grep -q '^declare -a'
+ local __read_array_i=0
+ IFS=
+ read -r 'errs[__read_array_i++]'
+++ kube::log::errexit
+++ local 'err=0 0 1'
+++ set +o
+++ grep -qe '-o errexit'
+++ set +o xtrace
+ eval '[[ ${errs[--__read_array_i]} ]]'
++ [[ -n '' ]]
+ unset 'errs[__read_array_i]'
+ ((  0 != 0  ))
+ go list -m -f '{{if not .Main}}{{.Path}}{{end}}' all
go: github.com/veraison/go-cose@v1.2.0: invalid version: unknown revision v1.2.0
++ kube::log::errexit
++ local err=1
++ set +o
++ grep -qe '-o errexit'
++ set +o xtrace
++ kube::log::errexit
++ local err=1
++ grep -qe '-o errexit'
++ set +o
++ set +o xtrace
(END)

Kubernetes version

master

Cloud provider

irrelevant

OS version

Arch Linux 6.10.10-arch1-1

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)
@stlaz stlaz added the kind/bug Categorizes issue or PR as related to a bug. label Sep 25, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 25, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 25, 2024
@dims
Copy link
Member

dims commented Sep 25, 2024

v1.2.0 is still in go eco system:

Though it looks like it was retracted:

cc @kiashok @princepereira

Can you please open an issue in https://github.com/microsoft/hcsshim? and ping the MSFT folks i cc'ed above to get a new release of hcsshim out?

( Looks like you are trying to build with a strict GOPROXY GOSUMDB etc and caught this! )

@stlaz
Copy link
Member Author

stlaz commented Sep 25, 2024

I added a comment to microsoft/hcsshim#2162 (comment), I'll try to see if I can fetch these two :)

@stlaz stlaz changed the title The vendor is broken The update-vendor.sh is broken with GOPROXY=direct Sep 25, 2024
@liggitt liggitt added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker labels Sep 25, 2024
@liggitt liggitt added this to the v1.31 milestone Sep 25, 2024
@liggitt
Copy link
Member

liggitt commented Sep 25, 2024 •
edited
Loading

Adding to the milestone as a blocker to make sure we don't release before resolving this

(though this is yet another reason why we are glad we vendor deps)

@dims
Copy link
Member

dims commented Sep 25, 2024

good call @liggitt thanks

This was referenced Sep 25, 2024
Merged
Closed
@neolit123
Copy link
Member

/sig architecture
/area code-organization

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/code-organization Issues or PRs related to kubernetes code organization and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 26, 2024
@drewhagen
Copy link
Member

Double checking, is this meant to be on the 1.32 milestone or 1.31?

@liggitt liggitt modified the milestones: v1.31, v1.32 Oct 9, 2024
@liggitt
Copy link
Member

liggitt commented Oct 9, 2024

Oops, 1.32

@liggitt
Copy link
Member

liggitt commented Oct 9, 2024

Isn't this fixed by #127824 ?

@dims
Copy link
Member

dims commented Oct 10, 2024

Isn't this fixed by #127824 ?

@liggitt yep. should be fixed now.

/close

@k8s-ci-robot
Copy link
Contributor

@dims: Closing this issue.

In response to this:

Isn't this fixed by #127824 ?

@liggitt yep. should be fixed now.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/code-organization Issues or PRs related to kubernetes code organization kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-blocker sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
[sig-release] Bug Triage
Archived in project
Milestone
v1.32
Development

Successfully merging a pull request may close this issue.

Update hcsshim to v0.12.7 kiashok/kiashok-k8s
6 participants
@dims @neolit123 @stlaz @liggitt @drewhagen @k8s-ci-robot