Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests to client-go/tools/cache/listers.go #124412

Open
skitt opened this issue Apr 19, 2024 · 7 comments · May be fixed by #125102
Open

Add unit tests to client-go/tools/cache/listers.go #124412

skitt opened this issue Apr 19, 2024 · 7 comments · May be fixed by #125102
Assignees
@skitt @0xMALVEE
Labels
area/client-libraries help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@skitt
Copy link
Member

skitt commented Apr 19, 2024

What would you like to be added?

https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/client-go/tools/cache/listers.go has no unit tests, it would be good to have some.

Why is this needed?

Ensure expected behaviour is checked and preserved.
@skitt skitt added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 19, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 19, 2024
@skitt
Copy link
Member Author

skitt commented Apr 19, 2024

/assign @skitt

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 19, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skitt skitt mentioned this issue Apr 19, 2024
Merged
@thockin thockin added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. area/client-libraries sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Apr 19, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 19, 2024
@thockin thockin added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 19, 2024
@sekharbinyan
Copy link

/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 2, 2024
@0xMALVEE
Copy link

@skitt can I do this issue or you are already doing it?

@skitt
Copy link
Member Author

skitt commented May 23, 2024

@0xMALVEE please go ahead, I haven’t started working on this.

@0xMALVEE
Copy link

/assign @0xMALVEE

@0xMALVEE 0xMALVEE linked a pull request May 23, 2024 that will close this issue
Open
@BenTheElder
Copy link
Member

/remove-sig testing
(we don't own test cases, we own the test framework, tooling, CI automation, etc. SIG api-machinery would own these tests, when in doubt, check the SIG charter.md)

@k8s-ci-robot k8s-ci-robot removed the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skitt skitt

@0xMALVEE 0xMALVEE

Labels
area/client-libraries help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add unit tests to client-go/tools/cache/listers.go 0xMALVEE/kubernetes
6 participants
@BenTheElder @skitt @thockin @k8s-ci-robot @0xMALVEE @sekharbinyan