-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow compression of json response body using Accept-Encoding header #110349
Comments
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle rotten |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale
/lifecycle frozen
|
☹ |
/transfer kubernetes |
BTW, for extra credit: support hop-by-hop compression too. Of course, Clients can combine what they negotiate, too: for example, preferring You don't have to restrict compression to JSON response bodies (per the issue title) …or even to responses. The API server can allow clients to hop-by-hop compress a request body, too (using the Because clients that understand hop-by-hop compression typically implement it properly, and only for HTTP/1.1 requests, adding hop-by-hop compression support is low impact / low risk. We could implement that first to get feedback on the implementation and then later migrate to end-to-end compression (which clients and proxies often do get wrong). PS. https://datatracker.ietf.org/doc/html/rfc7540 forbids HTTP/2 clients from requesting hop-by-hop response body compression, and it looks like HTTP/3 will forbid it too. I'm not suggesting that hop-by-hop compression for those protocols is likely; that's a different and bigger question. |
/sig api-machinery |
/priority backlog |
/triage accepted |
@fedebongio: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Interestingly the original issue should be fixed, accept encoding is what we key compression off of. Possible to close? |
As per #77449 this has been in Kube for a while. Please reopen if the original request was different. Re: hop by hop that should be a separate issue. |
JSON payload returned by Kubernetes can be very large on GET requests when there are a lot of managed resources in the cluster.
Currently it is not possible to specify that large response bodies should be compressed;
Accept-Encoding
header is ignored by the apiserver.Specifying the Accept-Encoding header on a GET request should cause the k8s apiserver to respond with response Body compressed with the given encoding sceme (e..g gzip, bzip2, etc.)
The text was updated successfully, but these errors were encountered: