Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe CRD gives confusing results for condition #104138

Closed
howardjohn opened this issue Aug 4, 2021 · 12 comments
Closed

Describe CRD gives confusing results for condition #104138

howardjohn opened this issue Aug 4, 2021 · 12 comments
Assignees
@swiftslee
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@howardjohn
Copy link
Contributor

All of the elements of a conditions list in kubectl describe are flattened together. For example (from Gateway CRD http://gateway-api.org/):

describe output:

Status:
  Conditions:
    Last Transition Time:  2021-08-04T21:48:19Z
    Message:               something
    Reason:                AddressNotAssigned
    Status:                False
    Type:                  Ready
    Last Transition Time:  2021-08-04T21:48:19Z
    Message:               something
    Reason:  ResourcesAvailable
    Status:  True
    Type:    Scheduled

This is confusing since it looks like a single condition that somehow repeats "Status" and other fields multiple times

Compare to -oyaml output, which has the - to delimit the list:
-oyaml output:

status:
  conditions:
  - lastTransitionTime: "2021-08-04T21:48:19Z"
    message: something
    reason: AddressNotAssigned
    status: "False"
    type: Ready
  - lastTransitionTime: "2021-08-04T21:48:19Z"
    message: something
    reason: ResourcesAvailable
    status: "True"
    type: Scheduled

/sig api-machinery
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 4, 2021
@pacoxu
Copy link
Member

pacoxu commented Aug 5, 2021

/sig cli
/kind bug

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/bug Categorizes issue or PR as related to a bug. labels Aug 5, 2021
@swiftslee
Copy link
Contributor

/assign

@caesarxuchao
Copy link
Member

/remove-sig api-machinery

I think the kubectl describe is more related to sig cli.

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Aug 5, 2021
@pacoxu
Copy link
Member

pacoxu commented Sep 10, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 10, 2021
@eddiezane
Copy link
Member

This is happening because we don't have a specific describer for CRD's. It currently uses the genericDescriber. That array is being printed here.

We could add an extra new line or a - at the start of the item? @howardjohn what would you like to see?

@eddiezane
Copy link
Member

@harjas27 would you like to take a look at this one since you were just in the describers?

@howardjohn
Copy link
Contributor Author

Newline or -, no big preference really. Both SGTM, whatever is more consistent I suppose

@eddiezane
Copy link
Member

Actually @soltysh would like to see this be achieved by kubernetes/enhancements#515 instead.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 14, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 13, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swiftslee swiftslee

Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/cli Categorizes an issue or PR as relevant to SIG CLI. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@howardjohn @eddiezane @pacoxu @caesarxuchao @k8s-ci-robot @swiftslee @k8s-triage-robot