-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose BindPodsQps and BindPodsBurst as cmd line flags #10377
Comments
@HaiyangDING can you please find authors who have touched the code recently (check out GitHub's history) and then @ mention them here directly? They'll be able to tell you whether we'll likely accept PRs for these fixes in the next couple weeks (we're pushing to 1.0 so are generally only accepting work on 1.0 features, tests, documentation, or bug fixes). Thank you--please ping if you need help! |
@mbforbes , I will look up the history to see if I can find the author. Besides, I am going to see if I can do anything for 1.0. Many thanks to your suggestion! |
Hi, I saw in the Git history that you have added limitation to pod burst qps and pod binding rate at 4004a68. In the patch, it is mentioned that BindPodsQps and BindPodsBurst should be exposed to cmd line flags. If you do not mind, may I send a PR to implement this? I just want to make some contribution to Kubernetes and have total respect of the work you have done:) Regards |
@HaiyangDING out of curiosity, do you have a use case in mind? (Would you like to push the limit higher/lower?). I'm totally fine exposing it as a command line flag if you need it, note however that we're currently in a code freeze working toward our 1.0 release (https://groups.google.com/forum/#!topic/kubernetes-announce/1voyC1d-T_o), so we might not be able to merge your pr right away. |
Hi, I do not have a specific use case right away. I wanted to implement this simply because I saw a TODO when reading the code. Luckily enough, it happens that I have had some contribution to the scheduler cmd line(#6967), so I felt that I could make more contribution for the community:) That is all my motivation. Besides, it is OK for me if the PR not be merged for some moment. PS: I have already written relevant code and tested it already. |
@kubernetes/sig-node-feature-requests |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
There is a TODO in the scheduler/factory stating that BindPodsQps and BindPodsBurst should be exposed as cmd line flags.
I would like to implement this, if no one is currently working on it.
The text was updated successfully, but these errors were encountered: