Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete legacy proxy path #10045

Closed
nikhiljindal opened this issue Jun 18, 2015 · 14 comments
Closed

Delete legacy proxy path #10045

nikhiljindal opened this issue Jun 18, 2015 · 14 comments
Assignees
@mbohlool
Labels
area/api Indicates an issue on api area. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. milestone/removed priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@nikhiljindal
Copy link
Contributor

We right now have two different URL paths in the v1 API for proxying to a pod:

/api/v1/proxy/namespaces/{namespaces}/pods/{name}/{path:*}
/api/v1/namespaces/{namespaces}/pods/{name}/proxy/{path:*}

This is because, we're in the process of moving towards using subresources (the second URL), but haven't deleted the legacy path yet (the first one).

This is to keep track of deleting the legacy proxy path.
@nikhiljindal nikhiljindal added priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 18, 2015
@nikhiljindal
Copy link
Contributor Author

cc @smarterclayton @bgrant0607

@smarterclayton
Copy link
Contributor

The service proxy needs to be moved, @csrwng either knows which issue it is or should be able to create the issue if it doesn't exist

@bgrant0607
Copy link
Member

#10038

@bgrant0607 bgrant0607 added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/api Indicates an issue on api area. labels Jun 18, 2015
@bgrant0607 bgrant0607 added this to the v1.0-post milestone Jun 18, 2015
@bgrant0607 bgrant0607 removed this from the v1.0-post milestone Jul 24, 2015
@bgrant0607 bgrant0607 added this to the v1.2-candidate milestone Oct 8, 2015
@lavalamp
Copy link
Member

lavalamp commented Feb 8, 2016

We need:

  • Make sure the "new" way works for all resources (services, pods, nodes) (I don't think this is true for 1.1)
  • Add to release notes that people need to transition while running 1.2 because it's going away for 1.3
  • Actually remove it after 1.2 branch is cut.

@liggitt
Copy link
Member

liggitt commented Feb 8, 2016

subresource proxying is still in progress for nodes and services:
#18010
#17493

those PRs are pending API approval (and only because the proxy options are considered an API type, despite only containing a path), but are ready otherwise

@lavalamp lavalamp modified the milestones: v1.2, v1.2-candidate Feb 10, 2016
@lavalamp
Copy link
Member

And we won't ever be able to remove the old way from the current API. Only from the new APIs.

@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 11, 2016 via email

@lavalamp
Copy link
Member

I will kick this to the next release once #17493 merges.

@lavalamp lavalamp modified the milestones: next-candidate, v1.2 Feb 22, 2016
@mbohlool
Copy link
Contributor

I think this had sufficient lead. It creates confusion for generated clients to have both connect and proxy in API. I am going to remove proxy as it is deprecated in 1.2

@mbohlool mbohlool modified the milestones: next-candidate, v1.9 Oct 20, 2017
@mbohlool mbohlool self-assigned this Oct 20, 2017
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Removed

@mbohlool @nikhiljindal

Important: This issue was missing labels required for the v1.9 milestone for more than 3 days:

priority: Must specify exactly one of priority/critical-urgent, priority/important-longterm or priority/important-soon.

Help

@k8s-github-robot k8s-github-robot removed this from the v1.9 milestone Oct 24, 2017
@bgrant0607 bgrant0607 added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Nov 9, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2018
@lukaszgryglicki lukaszgryglicki mentioned this issue Mar 1, 2018
Closed
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 9, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@liggitt
Copy link
Member

liggitt commented Apr 8, 2018

fixed by #59884

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbohlool mbohlool

Labels
area/api Indicates an issue on api area. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. milestone/removed priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@lavalamp @liggitt @smarterclayton @mbohlool @bgrant0607 @nikhiljindal @k8s-github-robot @k8s-ci-robot @fejta-bot