-
Notifications
You must be signed in to change notification settings - Fork 40k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #94196 from andrewsykim/registry-creds
kubelet: add alpha credential provider plugins
- Loading branch information
Showing
51 changed files
with
3,277 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test") | ||
|
|
||
| go_library( | ||
| name = "go_default_library", | ||
| srcs = [ | ||
| "config.go", | ||
| "plugin.go", | ||
| ], | ||
| importpath = "k8s.io/kubernetes/pkg/credentialprovider/plugin", | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| "//pkg/credentialprovider:go_default_library", | ||
| "//pkg/kubelet/apis/config:go_default_library", | ||
| "//pkg/kubelet/apis/config/v1alpha1:go_default_library", | ||
| "//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library", | ||
| "//staging/src/k8s.io/apimachinery/pkg/runtime/schema:go_default_library", | ||
| "//staging/src/k8s.io/apimachinery/pkg/runtime/serializer:go_default_library", | ||
| "//staging/src/k8s.io/apimachinery/pkg/runtime/serializer/json:go_default_library", | ||
| "//staging/src/k8s.io/apimachinery/pkg/util/validation/field:go_default_library", | ||
| "//staging/src/k8s.io/client-go/tools/cache:go_default_library", | ||
| "//staging/src/k8s.io/kubelet/pkg/apis/credentialprovider:go_default_library", | ||
| "//staging/src/k8s.io/kubelet/pkg/apis/credentialprovider/install:go_default_library", | ||
| "//staging/src/k8s.io/kubelet/pkg/apis/credentialprovider/v1alpha1:go_default_library", | ||
| "//vendor/k8s.io/klog/v2:go_default_library", | ||
| ], | ||
| ) | ||
|
|
||
| filegroup( | ||
| name = "package-srcs", | ||
| srcs = glob(["**"]), | ||
| tags = ["automanaged"], | ||
| visibility = ["//visibility:private"], | ||
| ) | ||
|
|
||
| filegroup( | ||
| name = "all-srcs", | ||
| srcs = [":package-srcs"], | ||
| tags = ["automanaged"], | ||
| visibility = ["//visibility:public"], | ||
| ) | ||
|
|
||
| go_test( | ||
| name = "go_default_test", | ||
| srcs = [ | ||
| "config_test.go", | ||
| "plugin_test.go", | ||
| ], | ||
| embed = [":go_default_library"], | ||
| deps = [ | ||
| "//pkg/credentialprovider:go_default_library", | ||
| "//pkg/kubelet/apis/config:go_default_library", | ||
| "//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library", | ||
| "//staging/src/k8s.io/apimachinery/pkg/runtime:go_default_library", | ||
| "//staging/src/k8s.io/client-go/tools/cache:go_default_library", | ||
| "//staging/src/k8s.io/kubelet/pkg/apis/credentialprovider:go_default_library", | ||
| "//staging/src/k8s.io/kubelet/pkg/apis/credentialprovider/v1alpha1:go_default_library", | ||
| ], | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| /* | ||
| Copyright 2020 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package plugin | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "io/ioutil" | ||
| "strings" | ||
|
|
||
| "k8s.io/apimachinery/pkg/util/validation/field" | ||
| "k8s.io/kubernetes/pkg/credentialprovider" | ||
| kubeletconfig "k8s.io/kubernetes/pkg/kubelet/apis/config" | ||
| ) | ||
|
|
||
| // readCredentialProviderConfigFile receives a path to a config file and decodes it | ||
| // into the internal CredentialProviderConfig type. | ||
| func readCredentialProviderConfigFile(configPath string) (*kubeletconfig.CredentialProviderConfig, error) { | ||
| if configPath == "" { | ||
| return nil, fmt.Errorf("credential provider config path is empty") | ||
| } | ||
|
|
||
| data, err := ioutil.ReadFile(configPath) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("unable to read external registry credential provider configuration from %q: %v", configPath, err) | ||
| } | ||
|
|
||
| config, err := decode(data) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("error decoding config %s: %v", configPath, err) | ||
| } | ||
|
|
||
| return config, nil | ||
| } | ||
|
|
||
| // decode decodes data into the internal CredentialProviderConfig type. | ||
| func decode(data []byte) (*kubeletconfig.CredentialProviderConfig, error) { | ||
| obj, gvk, err := codecs.UniversalDecoder().Decode(data, nil, nil) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| if gvk.Kind != "CredentialProviderConfig" { | ||
| return nil, fmt.Errorf("failed to decode %q (wrong Kind)", gvk.Kind) | ||
| } | ||
|
|
||
| if gvk.Group != kubeletconfig.GroupName { | ||
| return nil, fmt.Errorf("failed to decode CredentialProviderConfig, unexpected Group: %s", gvk.Group) | ||
| } | ||
|
|
||
| if internalConfig, ok := obj.(*kubeletconfig.CredentialProviderConfig); ok { | ||
| return internalConfig, nil | ||
| } | ||
|
|
||
| return nil, fmt.Errorf("unable to convert %T to *CredentialProviderConfig", obj) | ||
| } | ||
|
|
||
| // validateCredentialProviderConfig validates CredentialProviderConfig. | ||
| func validateCredentialProviderConfig(config *kubeletconfig.CredentialProviderConfig) field.ErrorList { | ||
| allErrs := field.ErrorList{} | ||
|
|
||
| if len(config.Providers) == 0 { | ||
| allErrs = append(allErrs, field.Required(field.NewPath("providers"), "at least 1 item in plugins is required")) | ||
| } | ||
|
|
||
| fieldPath := field.NewPath("providers") | ||
| for _, provider := range config.Providers { | ||
| if strings.Contains(provider.Name, "/") { | ||
| allErrs = append(allErrs, field.Invalid(fieldPath.Child("name"), provider.Name, "provider name cannot contain '/'")) | ||
| } | ||
|
|
||
| if strings.Contains(provider.Name, " ") { | ||
| allErrs = append(allErrs, field.Invalid(fieldPath.Child("name"), provider.Name, "provider name cannot contain spaces")) | ||
| } | ||
|
|
||
| if provider.Name == "." { | ||
| allErrs = append(allErrs, field.Invalid(fieldPath.Child("name"), provider.Name, "provider name cannot be '.'")) | ||
| } | ||
|
|
||
| if provider.Name == ".." { | ||
| allErrs = append(allErrs, field.Invalid(fieldPath.Child("name"), provider.Name, "provider name cannot be '..'")) | ||
| } | ||
|
|
||
| if provider.APIVersion == "" { | ||
| allErrs = append(allErrs, field.Required(fieldPath.Child("apiVersion"), "apiVersion is required")) | ||
| } else if _, ok := apiVersions[provider.APIVersion]; !ok { | ||
| validAPIVersions := []string{} | ||
| for apiVersion := range apiVersions { | ||
| validAPIVersions = append(validAPIVersions, apiVersion) | ||
| } | ||
|
|
||
| allErrs = append(allErrs, field.NotSupported(fieldPath.Child("apiVersion"), provider.APIVersion, validAPIVersions)) | ||
| } | ||
|
|
||
| if len(provider.MatchImages) == 0 { | ||
| allErrs = append(allErrs, field.Required(fieldPath.Child("matchImages"), "at least 1 item in matchImages is required")) | ||
| } | ||
|
|
||
| for _, matchImage := range provider.MatchImages { | ||
| if _, err := credentialprovider.ParseSchemelessURL(matchImage); err != nil { | ||
| allErrs = append(allErrs, field.Invalid(fieldPath.Child("matchImages"), matchImage, fmt.Sprintf("match image is invalid: %s", err.Error()))) | ||
| } | ||
| } | ||
|
|
||
| if provider.DefaultCacheDuration == nil { | ||
| allErrs = append(allErrs, field.Required(fieldPath.Child("defaultCacheDuration"), "defaultCacheDuration is required")) | ||
| } | ||
|
|
||
| if provider.DefaultCacheDuration != nil && provider.DefaultCacheDuration.Duration < 0 { | ||
| allErrs = append(allErrs, field.Invalid(fieldPath.Child("defaultCacheDuration"), provider.DefaultCacheDuration.Duration, "defaultCacheDuration must be greater than or equal to 0")) | ||
| } | ||
| } | ||
|
|
||
| return allErrs | ||
| } |
Oops, something went wrong.