Skip to content

Commit

Permalink
Merge pull request #129430 from MadhavJivrajani/go124-webhook-regex-ut
Browse files Browse the repository at this point in the history
[go1.24] webhook: alter regex to account for x509sha1 GODEBUG removal
  • Loading branch information
k8s-ci-robot authored Jan 6, 2025
2 parents b7ef173 + cff0f40 commit c3f3fdc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions staging/src/k8s.io/apiserver/pkg/util/webhook/webhook_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -406,14 +406,14 @@ func TestTLSConfig(t *testing.T) {
test: "server cert with SHA1 signature",
clientCA: caCert,
serverCert: append(append(sha1ServerCertInter, byte('\n')), caCertInter...), serverKey: serverKey,
errRegex: "x509: cannot verify signature: insecure algorithm SHA1-RSA \\(temporarily override with GODEBUG=x509sha1=1\\)",
errRegex: "x509: cannot verify signature: insecure algorithm SHA1-RSA",
increaseSHA1SignatureWarnCounter: true,
},
{
test: "server cert signed by an intermediate CA with SHA1 signature",
clientCA: caCert,
serverCert: append(append(serverCertInterSHA1, byte('\n')), caCertInterSHA1...), serverKey: serverKey,
errRegex: "x509: cannot verify signature: insecure algorithm SHA1-RSA \\(temporarily override with GODEBUG=x509sha1=1\\)",
errRegex: "x509: cannot verify signature: insecure algorithm SHA1-RSA",
increaseSHA1SignatureWarnCounter: true,
},
}
Expand Down

0 comments on commit c3f3fdc

Please sign in to comment.