Skip to content

Commit

Permalink
Log HTTP InternalServerErrors in the kubelet
Browse files Browse the repository at this point in the history
Otherwise we just get a stack trace and no message
  • Loading branch information
justinsb committed Mar 4, 2015
1 parent 6f6218c commit b681a45
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion pkg/kubelet/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ func (s *Server) InstallDebuggingHandlers() {

// error serializes an error object into an HTTP response.
func (s *Server) error(w http.ResponseWriter, err error) {
http.Error(w, fmt.Sprintf("Internal Error: %v", err), http.StatusInternalServerError)
msg := fmt.Sprintf("Internal Error: %v", err)
glog.Infof("HTTP InternalServerError: %s", msg)
http.Error(w, msg, http.StatusInternalServerError)
}

func isValidDockerVersion(ver []uint) (bool, string) {
Expand Down

0 comments on commit b681a45

Please sign in to comment.