kubectl config set hangs on some invalid property names #415

kubernetes · Jun 14, 2019 · ae386f3 · ae386f3
1 parent 333081e
commit ae386f3
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/pkg/kubectl/cmd/config/navigation_step_parser.go b/pkg/kubectl/cmd/config/navigation_step_parser.go
@@ -76,6 +76,8 @@ func newNavigationSteps(path string) (*navigationSteps, error) {
 			steps = append(steps, navigationStep{nextPart, fieldType})
 			currPartIndex += len(strings.Split(nextPart, "."))
 			currType = fieldType
+		default:
+			return nil, fmt.Errorf("unable to parse one or more field values of %v", path)
 		}
 	}
 

diff --git a/pkg/kubectl/cmd/config/navigation_step_parser_test.go b/pkg/kubectl/cmd/config/navigation_step_parser_test.go
@@ -72,6 +72,18 @@ func TestParseWithBadValue(t *testing.T) {
 	test.run(t)
 }
 
+func TestParseWithNoMatchingValue(t *testing.T) {
+	test := stepParserTest{
+		path: "users.jheiss.exec.command",
+		expectedNavigationSteps: navigationSteps{
+			steps: []navigationStep{},
+		},
+		expectedError: "unable to parse one or more field values of users.jheiss.exec",
+	}
+
+	test.run(t)
+}
+
 func (test stepParserTest) run(t *testing.T) {
 	actualSteps, err := newNavigationSteps(test.path)
 	if len(test.expectedError) != 0 {