Merge pull request #18321 from janetkuo/fix-deployment-getoldrcs

Fix bug when getting old RCs of a deployment
kubernetes · Dec 10, 2015 · aaa1fe6 · aaa1fe6 · k8s-teamcity-mesosphere · Dec 10, 2015
2 parents 9d1f07d + 524ec8b
commit aaa1fe6
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/pkg/util/deployment/deployment.go b/pkg/util/deployment/deployment.go
@@ -61,7 +61,11 @@ func GetOldRCs(deployment extensions.Deployment, c client.Interface) ([]*api.Rep
 		}
 	}
 	requiredRCs := []*api.ReplicationController{}
-	for _, value := range oldRCs {
+	// Note that go reuses the same memory location for every iteration,
+	// which means the 'value' returned from range will have the same address.
+	// Therefore, we should use the returned 'index' instead.
+	for i := range oldRCs {
+		value := oldRCs[i]
 		requiredRCs = append(requiredRCs, &value)
 	}
 	return requiredRCs, nil