Use switch rather than ifs for getPodStatusForReplicationController i…

…n pkg/describe.go
kubernetes · Nov 7, 2014 · a4261d0 · a4261d0
1 parent b695650
commit a4261d0
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/pkg/kubectl/describe.go b/pkg/kubectl/describe.go
@@ -222,13 +222,14 @@ func getPodStatusForReplicationController(c client.PodInterface, controller *api
 		return
 	}
 	for _, pod := range rcPods.Items {
-		if pod.CurrentState.Status == api.PodRunning {
+		switch pod.CurrentState.Status {
+		case api.PodRunning:
 			running++
-		} else if pod.CurrentState.Status == api.PodPending {
+		case api.PodPending:
 			waiting++
-		} else if pod.CurrentState.Status == api.PodSucceeded {
+		case api.PodSucceeded:
 			succeeded++
-		} else if pod.CurrentState.Status == api.PodFailed {
+		case api.PodFailed:
 			failed++
 		}
 	}