Skip to content

Commit

Permalink
Name change: s/timstclair/tallclair/
Browse files Browse the repository at this point in the history
  • Loading branch information
tallclair committed Jul 10, 2017
1 parent 0744964 commit a2f2e1d
Show file tree
Hide file tree
Showing 38 changed files with 55 additions and 55 deletions.
2 changes: 1 addition & 1 deletion OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ aliases:
- pmorie
- resouer
- sjpotter
- timstclair
- tallclair
- tmrts
- vishh
- yifan-gu
Expand Down
2 changes: 1 addition & 1 deletion api/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ reviewers:
- pwittrock
- roberthbailey
- ncdc
- timstclair
- tallclair
- yifan-gu
- eparis
- mwielgus
Expand Down
2 changes: 1 addition & 1 deletion hack/update_owners.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def get_maintainers():
"nikhiljindal", "piosz", "pmorie", "pwittrock", "Q-Lee", "quinton-hoole",
"Random-Liu", "rmmh", "roberthbailey", "saad-ali", "smarterclayton",
"soltysh", "spxtr", "sttts", "thelinuxfoundation", "thockin",
"timothysc", "timstclair", "vishh", "wojtek-t", "xiang90", "yifan-gu",
"timothysc", "tallclair", "vishh", "wojtek-t", "xiang90", "yifan-gu",
"yujuhong", "zmerlynn"}
return sorted(ret - SKIP_MAINTAINERS)

Expand Down
2 changes: 1 addition & 1 deletion pkg/api/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ reviewers:
- pwittrock
- roberthbailey
- ncdc
- timstclair
- tallclair
- yifan-gu
- eparis
- mwielgus
Expand Down
2 changes: 1 addition & 1 deletion pkg/api/testapi/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ reviewers:
- nikhiljindal
- bprashanth
- erictune
- timstclair
- tallclair
- eparis
- soltysh
- madhusudancs
Expand Down
2 changes: 1 addition & 1 deletion pkg/api/testing/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ reviewers:
- justinsb
- pwittrock
- roberthbailey
- timstclair
- tallclair
- yifan-gu
- eparis
- soltysh
Expand Down
2 changes: 1 addition & 1 deletion pkg/api/v1/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ reviewers:
- justinsb
- roberthbailey
- ncdc
- timstclair
- tallclair
- eparis
- timothysc
- piosz
Expand Down
2 changes: 1 addition & 1 deletion pkg/api/validation/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ reviewers:
- justinsb
- pwittrock
- roberthbailey
- timstclair
- tallclair
- eparis
- soltysh
- piosz
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ reviewers:
- justinsb
- pwittrock
- ncdc
- timstclair
- tallclair
- yifan-gu
- eparis
- mwielgus
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/apps/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ reviewers:
- sttts
- saad-ali
- ncdc
- timstclair
- tallclair
- timothysc
- dims
- errordeveloper
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/extensions/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ reviewers:
- janetkuo
- justinsb
- ncdc
- timstclair
- tallclair
- mwielgus
- timothysc
- soltysh
Expand Down
2 changes: 1 addition & 1 deletion pkg/client/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ reviewers:
- justinsb
- roberthbailey
- ncdc
- timstclair
- tallclair
- yifan-gu
- eparis
- mwielgus
Expand Down
2 changes: 1 addition & 1 deletion pkg/client/unversioned/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ reviewers:
- zmerlynn
- janetkuo
- ncdc
- timstclair
- tallclair
- mwielgus
- timothysc
- feiskyer
Expand Down
4 changes: 2 additions & 2 deletions pkg/features/kube_features.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const (
// // alpha: v1.X
// MyFeature utilfeature.Feature = "MyFeature"

// owner: @timstclair
// owner: @tallclair
// beta: v1.4
AppArmor utilfeature.Feature = "AppArmor"

Expand All @@ -44,7 +44,7 @@ const (
// alpha: v1.4
DynamicKubeletConfig utilfeature.Feature = "DynamicKubeletConfig"

// owner: timstclair
// owner: tallclair
// alpha: v1.5
//
// StreamingProxyRedirects controls whether the apiserver should intercept (and follow)
Expand Down
2 changes: 1 addition & 1 deletion pkg/kubelet/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ approvers:
- Random-Liu
- dchen1107
- derekwaynecarr
- timstclair
- tallclair
- vishh
- yujuhong
reviewers:
Expand Down
2 changes: 1 addition & 1 deletion pkg/kubelet/dockershim/docker_streaming.go
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func (ds *dockerService) PortForward(req *runtimeapi.PortForwardRequest) (*runti
if err != nil {
return nil, err
}
// TODO(timstclair): Verify that ports are exposed.
// TODO(tallclair): Verify that ports are exposed.
return ds.streamingServer.GetPortForward(req)
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/kubelet/kubelet_node_status.go
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ func (kl *Kubelet) setNodeReadyCondition(node *v1.Node) {
}

// Append AppArmor status if it's enabled.
// TODO(timstclair): This is a temporary message until node feature reporting is added.
// TODO(tallclair): This is a temporary message until node feature reporting is added.
if newNodeReadyCondition.Status == v1.ConditionTrue &&
kl.appArmorValidator != nil && kl.appArmorValidator.ValidateHost() == nil {
newNodeReadyCondition.Message = fmt.Sprintf("%s. AppArmor enabled", newNodeReadyCondition.Message)
Expand Down
2 changes: 1 addition & 1 deletion pkg/kubelet/kubelet_pods.go
Original file line number Diff line number Diff line change
Expand Up @@ -1418,7 +1418,7 @@ func (kl *Kubelet) RunInContainer(podFullName string, podUID types.UID, containe
if container == nil {
return nil, fmt.Errorf("container not found (%q)", containerName)
}
// TODO(timstclair): Pass a proper timeout value.
// TODO(tallclair): Pass a proper timeout value.
return kl.runner.RunInContainer(container.ID, cmd, 0)
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/kubelet/kuberuntime/kuberuntime_container.go
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,7 @@ func (m *kubeGenericRuntimeManager) GetAttach(id kubecontainer.ContainerID, stdi
// RunInContainer synchronously executes the command in the container, and returns the output.
func (m *kubeGenericRuntimeManager) RunInContainer(id kubecontainer.ContainerID, cmd []string, timeout time.Duration) ([]byte, error) {
stdout, stderr, err := m.runtimeService.ExecSync(id.ID, cmd, 0)
// NOTE(timstclair): This does not correctly interleave stdout & stderr, but should be sufficient
// NOTE(tallclair): This does not correctly interleave stdout & stderr, but should be sufficient
// for logging purposes. A combined output option will need to be added to the ExecSyncRequest
// if more precise output ordering is ever required.
return append(stdout, stderr...), err
Expand Down
2 changes: 1 addition & 1 deletion pkg/kubelet/lifecycle/handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func (hr *HandlerRunner) Run(containerID kubecontainer.ContainerID, pod *v1.Pod,
switch {
case handler.Exec != nil:
var msg string
// TODO(timstclair): Pass a proper timeout value.
// TODO(tallclair): Pass a proper timeout value.
output, err := hr.commandRunner.RunInContainer(containerID, handler.Exec.Command, 0)
if err != nil {
msg := fmt.Sprintf("Exec lifecycle hook (%v) for Container %q in Pod %q failed - error: %v, message: %q", handler.Exec.Command, container.Name, format.Pod(pod), err, string(output))
Expand Down
2 changes: 1 addition & 1 deletion pkg/kubelet/server/stats/summary.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func (sp *summaryProviderImpl) Get() (*stats.Summary, error) {
}
}

// TODO(timstclair): Consider returning a best-effort response if any of the following errors
// TODO(tallclair): Consider returning a best-effort response if any of the following errors
// occur.
node, err := sp.provider.GetNode()
if err != nil {
Expand Down
6 changes: 3 additions & 3 deletions pkg/kubelet/server/streaming/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ var DefaultConfig = Config{
SupportedPortForwardProtocols: portforward.SupportedProtocols,
}

// TODO(timstclair): Add auth(n/z) interface & handling.
// TODO(tallclair): Add auth(n/z) interface & handling.
func NewServer(config Config, runtime Runtime) (Server, error) {
s := &server{
config: config,
Expand Down Expand Up @@ -193,7 +193,7 @@ func (s *server) GetPortForward(req *runtimeapi.PortForwardRequest) (*runtimeapi

func (s *server) Start(stayUp bool) error {
if !stayUp {
// TODO(timstclair): Implement this.
// TODO(tallclair): Implement this.
return errors.New("stayUp=false is not yet implemented")
}

Expand All @@ -210,7 +210,7 @@ func (s *server) Start(stayUp bool) error {
}

func (s *server) Stop() error {
// TODO(timstclair): Implement this.
// TODO(tallclair): Implement this.
return errors.New("not yet implemented")
}

Expand Down
2 changes: 1 addition & 1 deletion pkg/master/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ reviewers:
- justinsb
- roberthbailey
- ncdc
- timstclair
- tallclair
- mwielgus
- timothysc
- soltysh
Expand Down
2 changes: 1 addition & 1 deletion pkg/registry/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ reviewers:
- pwittrock
- roberthbailey
- ncdc
- timstclair
- tallclair
- eparis
- mwielgus
- timothysc
Expand Down
2 changes: 1 addition & 1 deletion pkg/security/podsecuritypolicy/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ func (s *simpleProvider) ValidatePodSecurityContext(pod *api.Pod, fldPath *field

allErrs = append(allErrs, s.strategies.SysctlsStrategy.Validate(pod)...)

// TODO(timstclair): ValidatePodSecurityContext should be renamed to ValidatePod since its scope
// TODO(tallclair): ValidatePodSecurityContext should be renamed to ValidatePod since its scope
// is not limited to the PodSecurityContext.
if len(pod.Spec.Volumes) > 0 && !psputil.PSPAllowsAllVolumes(s.psp) {
allowedVolumes := psputil.FSTypeToStringSet(s.psp.Spec.Volumes)
Expand Down
4 changes: 2 additions & 2 deletions plugin/pkg/admission/noderestriction/OWNERS
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
approvers:
- deads2k
- liggitt
- timstclair
- tallclair
reviewers:
- deads2k
- liggitt
- timstclair
- tallclair
4 changes: 2 additions & 2 deletions plugin/pkg/auth/authorizer/node/OWNERS
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
approvers:
- timstclair
- tallclair
- liggitt
- deads2k
reviewers:
- timstclair
- tallclair
- liggitt
- deads2k
- ericchiang
2 changes: 1 addition & 1 deletion staging/src/k8s.io/apimachinery/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ reviewers:
- gmarek
- sttts
- ncdc
- timstclair
- tallclair
2 changes: 1 addition & 1 deletion staging/src/k8s.io/apimachinery/pkg/api/errors/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ reviewers:
- erictune
- saad-ali
- janetkuo
- timstclair
- tallclair
- eparis
- timothysc
- dims
Expand Down
2 changes: 1 addition & 1 deletion staging/src/k8s.io/apimachinery/pkg/api/resource/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ reviewers:
- mikedanese
- saad-ali
- janetkuo
- timstclair
- tallclair
- eparis
- timothysc
- jbeda
Expand Down
2 changes: 1 addition & 1 deletion staging/src/k8s.io/apiserver/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@ reviewers:
- liggitt
- sttts
- ncdc
- timstclair
- tallclair
- timothysc
4 changes: 2 additions & 2 deletions staging/src/k8s.io/apiserver/pkg/features/kube_features.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,14 @@ const (
// // alpha: v1.4
// MyFeature() bool

// owner: timstclair
// owner: tallclair
// alpha: v1.5
//
// StreamingProxyRedirects controls whether the apiserver should intercept (and follow)
// redirects from the backend (Kubelet) for streaming requests (exec/attach/port-forward).
StreamingProxyRedirects utilfeature.Feature = "StreamingProxyRedirects"

// owner: timstclair
// owner: tallclair
// alpha: v1.7
//
// AdvancedAuditing enables a much more general API auditing pipeline, which includes support for
Expand Down
2 changes: 1 addition & 1 deletion staging/src/k8s.io/apiserver/pkg/storage/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ reviewers:
- mikedanese
- liggitt
- ncdc
- timstclair
- tallclair
- timothysc
- hongchaodeng
- krousey
Expand Down
2 changes: 1 addition & 1 deletion staging/src/k8s.io/apiserver/pkg/storage/etcd/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ reviewers:
- luxas
- janetkuo
- roberthbailey
- timstclair
- tallclair
- timothysc
- dims
- hongchaodeng
Expand Down
2 changes: 1 addition & 1 deletion staging/src/k8s.io/client-go/OWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ reviewers:
- justinsb
- roberthbailey
- ncdc
- timstclair
- tallclair
- yifan-gu
- eparis
- mwielgus
Expand Down
2 changes: 1 addition & 1 deletion test/e2e_node/OWNERS
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
approvers:
- Random-Liu
- timstclair
- tallclair
- vishh
- derekwaynecarr
reviewers:
Expand Down
2 changes: 1 addition & 1 deletion test/e2e_node/apparmor_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ func expectSoftRejection(status v1.PodStatus) {
}

func isAppArmorEnabled() bool {
// TODO(timstclair): Pass this through the image setup rather than hardcoding.
// TODO(tallclair): Pass this through the image setup rather than hardcoding.
if strings.Contains(framework.TestContext.NodeName, "-gci-dev-") {
gciVersionRe := regexp.MustCompile("-gci-dev-([0-9]+)-")
matches := gciVersionRe.FindStringSubmatch(framework.TestContext.NodeName)
Expand Down
Loading

0 comments on commit a2f2e1d

Please sign in to comment.