Merge pull request #12831 from thockin/nodeport-optional

Make nodePort optional in v1 API
kubernetes · Aug 17, 2015 · 736945f · 736945f
2 parents 19bb04f + 75941af
commit 736945f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/api/swagger-spec/v1.json b/api/swagger-spec/v1.json
@@ -13446,8 +13446,7 @@
    "v1.ServicePort": {
     "id": "v1.ServicePort",
     "required": [
-     "port",
-     "nodePort"
+     "port"
     ],
     "properties": {
      "name": {

diff --git a/pkg/api/v1/types.go b/pkg/api/v1/types.go
@@ -1178,7 +1178,7 @@ type ServicePort struct {
 
 	// The port on each node on which this service is exposed.
 	// Default is to auto-allocate a port if the ServiceType of this Service requires one.
-	NodePort int `json:"nodePort" description:"the port on each node on which this service is exposed when type=NodePort or LoadBalancer; usually assigned by the system; if specified, it will be allocated to the service if unused or else creation of the service will fail; see http://releases.k8s.io/HEAD/docs/user-guide/services.md#type--nodeport"`
+	NodePort int `json:"nodePort,omitempty" description:"the port on each node on which this service is exposed when type=NodePort or LoadBalancer; usually assigned by the system; if specified, it will be allocated to the service if unused or else creation of the service will fail; see http://releases.k8s.io/HEAD/docs/user-guide/services.md#type--nodeport"`
 }
 
 // Service is a named abstraction of software service (for example, mysql) consisting of local port